Skip to content

treewide: remove issue #56943 workarounds#208268

Closed
Artturin wants to merge 558 commits intoNixOS:masterfrom
Artturin:removegirworkarounds1
Closed

treewide: remove issue #56943 workarounds#208268
Artturin wants to merge 558 commits intoNixOS:masterfrom
Artturin:removegirworkarounds1

Conversation

@Artturin
Copy link
Member

@Artturin Artturin commented Dec 29, 2022 •
edited
Loading

checked with diffoscope+difflog and launching the programs

i have fixed that issue in my other gir PRs https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+author%3Aartturin+gobject-introspection+

Result of nixpkgs-review pr 208268 run on x86_64-linux 1

69 packages built:
  • adl
  • arandr
  • bada-bib
  • beets (beetsPackages.beets ,beetsPackages.beets-stable)
  • beets-unstable (beetsPackages.beets-unstable)
  • beetsPackages.alternatives
  • beetsPackages.beets-minimal
  • beetsPackages.copyartifacts
  • beetsPackages.extrafiles
  • blanket
  • bubblemail
  • cambalache
  • cozy
  • curtail
  • devede
  • dfeet
  • gaphor
  • giara
  • gnome-feeds
  • gnome-keysign
  • gnome-photos
  • gnome-secrets
  • gnome.accerciser
  • gnome.gnome-tweaks
  • gpodder
  • gtg
  • guake
  • hamster
  • input-remapper
  • kazam
  • kupfer
  • lutris
  • lutris-free
  • lutris-unwrapped
  • mcomix
  • meld
  • minigalaxy
  • mpdris2
  • onboard
  • pantheon.elementary-greeter
  • pantheon.elementary-session-settings
  • pantheon.switchboard-plug-a11y
  • pantheon.switchboard-plug-keyboard
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-with-indicators
  • pick-colour-picker
  • piper
  • pitivi
  • printrun
  • protonvpn-gui
  • python310Packages.dogtail
  • python39Packages.dogtail
  • rabbitvcs
  • rednotebook
  • sc-controller
  • solfege
  • sonata
  • sublime-music
  • terminator
  • trackma
  • trackma-curses
  • trackma-gtk
  • trackma-qt
  • virt-manager
  • wike
  • xfce.catfish
  • xsser
  • zim
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Artturin Artturin requested a review from jtojnar as a code owner December 29, 2022 19:27
@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation labels Dec 29, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 29, 2022
@Artturin Artturin force-pushed the removegirworkarounds1 branch from 0ed64cd to 71edff9 Compare December 29, 2022 21:05
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 29, 2022
@Artturin Artturin force-pushed the removegirworkarounds1 branch 2 times, most recently from dde2be7 to df1d4e4 Compare December 29, 2022 21:30
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Dec 29, 2022
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 30, 2022

Result of nixpkgs-review pr 208268 run on x86_64-linux 1

69 packages built:
  • adl
  • arandr
  • bada-bib
  • beets (beetsPackages.beets ,beetsPackages.beets-stable)
  • beets-unstable (beetsPackages.beets-unstable)
  • beetsPackages.alternatives
  • beetsPackages.beets-minimal
  • beetsPackages.copyartifacts
  • beetsPackages.extrafiles
  • blanket
  • bubblemail
  • cambalache
  • cozy
  • curtail
  • devede
  • dfeet
  • gaphor
  • giara
  • gnome-feeds
  • gnome-keysign
  • gnome-photos
  • gnome-secrets
  • gnome.accerciser
  • gnome.gnome-tweaks
  • gpodder
  • gtg
  • guake
  • hamster
  • input-remapper
  • kazam
  • kupfer
  • lutris
  • lutris-free
  • lutris-unwrapped
  • mcomix
  • meld
  • minigalaxy
  • mpdris2
  • onboard
  • pantheon.elementary-greeter
  • pantheon.elementary-session-settings
  • pantheon.switchboard-plug-a11y
  • pantheon.switchboard-plug-keyboard
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-with-indicators
  • pick-colour-picker
  • piper
  • pitivi
  • printrun
  • protonvpn-gui
  • python310Packages.dogtail
  • python39Packages.dogtail
  • rabbitvcs
  • rednotebook
  • sc-controller
  • solfege
  • sonata
  • sublime-music
  • terminator
  • trackma
  • trackma-curses
  • trackma-gtk
  • trackma-qt
  • virt-manager
  • wike
  • xfce.catfish
  • xsser
  • zim

@jtojnar
Copy link
Member

jtojnar commented Dec 30, 2022 •
edited
Loading

Note that some of the other setup hooks (¿was it gdk-pixbuf, or the maybe the removed hicolor-icon-theme?) may suffer from the same problem, even though the comment, if present, only tends to mention g-i.

Running the programs might not be a best check, since many of the necessary variables will likely already be present in the environment (propagated from e.g. terminal emulator or window manager). But if you checked the wrappers with diffoscope and there were no differences then it should be probably.

@Artturin Artturin marked this pull request as draft December 30, 2022 20:11
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 30, 2022
@Artturin Artturin force-pushed the removegirworkarounds1 branch from 5076fd0 to 47e82d0 Compare December 30, 2022 20:38
@ofborg ofborg bot added 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 30, 2022
@Artturin Artturin force-pushed the removegirworkarounds1 branch from 47e82d0 to 6c7d0fe Compare December 31, 2022 11:25
@Artturin
Copy link
Member Author

Artturin commented Dec 31, 2022

#208537

@Artturin Artturin force-pushed the removegirworkarounds1 branch from 6c7d0fe to df1d4e4 Compare December 31, 2022 19:13
@ofborg ofborg bot added the 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. label Dec 31, 2022
vcunat and others added 15 commits February 10, 2023 08:13
@vcunat
Merge NixOS#215557: postgresql: 15.2, 14.7, 13.10, 12.14, and 11.19
123c88b 
...into staging-next
@fabaff
Merge pull request NixOS#213544 from fabaff/watchdog-bump
806b928 
python310Packages.watchdog: 2.2.0 -> 2.2.1
@prusnak
Merge pull request NixOS#215284 from prusnak/portaudio-jack
4388586 
portaudio: build with jack support
@alyssais
rust-bindgen: 0.63.0 -> 0.64.0
d607d07 
Changelog[1] and my testing suggests generated bindings aren't going
to change much or at all.

[1]: https://github.com/rust-lang/rust-bindgen/blob/ae6817256ac557981906e93a1f866349db85053e/CHANGELOG.md
@github-actions
Merge master into staging-next
9be52f6
@erikarvstedt
python3Packages.flit-scm: Fix src hash
400212a 
The fetcher params were changed in the previous commit (de08f0b),
but the hash wasn't updated.
@vcunat
Merge branch 'master' into staging-next
3741288
@vcunat
Merge branch 'staging-next' into staging
13e8ec1
@mweinelt
Merge pull request NixOS#215678 from erikarvstedt/fix-flit-scm-src-2
016028b 
python3Packages.flit-scm: Fix src hash
@7c6f434c
Merge pull request NixOS#215584 from superherointj/fix-libsecret-non-…
bc1660f 
…deterministic-fail

libsecret: fix non-deterministic fail of test-collection
@github-actions
Merge master into staging-next
42cf9b7
@github-actions
Merge staging-next into staging
1c17819
@Artturin
Merge pull request NixOS#208537 from Artturin/makesetuphooksupportstr…
aaa9ea8 
…ictdeps
@Artturin
treewide: remove issue NixOS#56943 workarounds
431dbdc 
checked with diffoscope+difflog and launching the programs

i have fixed that issue in my other gir PRs
@Artturin
dogtail: remove issue 56943 workaround
c9a08bb 
and fix double wrapping

it still fails to launch though but its not a regression

$ ./result/bin/dogtail-logout
Traceback (most recent call last):
  File "/nix/store/az8mw2pmhbwlm08176wd62hn0hfzwv8s-python3.10-dogtail-0.9.11/bin/.dogtail-logout-wrapped", line 8, in <module>
    from dogtail.tree import *
  File "/nix/store/az8mw2pmhbwlm08176wd62hn0hfzwv8s-python3.10-dogtail-0.9.11/lib/python3.10/site-packages/dogtail/tree.py", line 5, in <module>
    from dogtail import predicate
  File "/nix/store/az8mw2pmhbwlm08176wd62hn0hfzwv8s-python3.10-dogtail-0.9.11/lib/python3.10/site-packages/dogtail/predicate.py", line 6, in <module>
    from gi.repository import GLib
ModuleNotFoundError: No module named 'gi'
@Artturin Artturin force-pushed the removegirworkarounds1 branch from df1d4e4 to c9a08bb Compare February 10, 2023 18:48
@github-actions github-actions bot added 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: kernel The Linux kernel 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: stdenv Standard environment 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: vim Advanced text editor 8.has: changelog This PR adds or changes release notes labels Feb 10, 2023
@Artturin Artturin closed this Feb 10, 2023
@Artturin Artturin deleted the removegirworkarounds1 branch February 10, 2023 18:50
@Artturin
Copy link
Member Author

Artturin commented Feb 10, 2023

#215715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: kernel The Linux kernel 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: stdenv Standard environment 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: vim Advanced text editor 6.topic: xfce The Xfce Desktop Environment 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.