Skip to content

Python pyside2/shiboken2: fix build issue for older python versions using libxcrypt#207829

Merged
bjornfor merged 2 commits intoNixOS:masterfrom
hellwolf:python-pysid2-libxcrypt
Dec 26, 2022
Merged

Python pyside2/shiboken2: fix build issue for older python versions using libxcrypt#207829
bjornfor merged 2 commits intoNixOS:masterfrom
hellwolf:python-pysid2-libxcrypt

Conversation

@hellwolf
Copy link
Contributor

@hellwolf hellwolf commented Dec 26, 2022

Description of changes

Building python.pkgs.pyside2|shiboken2 fails for python version older than 3.9, due to crypt.h header issue related to older glibc (#202262).

A similar issue can be found at #202262.

The fix is to use libxrypto for these older python versions.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Building python.pkgs.shiboken2 fails for python version older than 3.9,
due to crypt.h header issue related to older glibc (NixOS#202262).

The fix is to use libxrypto for these older python versions.
Building python.pkgs.pyside2 fails for python version older than 3.9,
due to crypt.h header issue related to older glibc (NixOS#202262).

The fix is to use libxrypto for these older python versions.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 26, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 26, 2022
@bjornfor bjornfor merged commit 9608226 into NixOS:master Dec 26, 2022
@bjornfor
Copy link
Contributor

Thanks!

@hellwolf
Copy link
Contributor Author

backport release-22.11

@github-actions
Copy link
Contributor

Successfully created backport PR #207957 for release-22.11.

@hellwolf hellwolf deleted the python-pysid2-libxcrypt branch May 27, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants