python38Packages.pydantic: fix build with libxcrypt#202262
Merged
mweinelt merged 1 commit intoNixOS:masterfrom Mar 10, 2023
Merged
python38Packages.pydantic: fix build with libxcrypt#202262mweinelt merged 1 commit intoNixOS:masterfrom
mweinelt merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 0
hellwolf
added a commit
to hellwolf/nixpkgs
that referenced
this pull request
Dec 26, 2022
Building python.pkgs.shiboken2 fails for python version older than 3.9, due to crypt.h header issue related to older glibc (NixOS#202262). The fix is to use libxrypto for these older python versions.
hellwolf
added a commit
to hellwolf/nixpkgs
that referenced
this pull request
Dec 26, 2022
Building python.pkgs.pyside2 fails for python version older than 3.9, due to crypt.h header issue related to older glibc (NixOS#202262). The fix is to use libxrypto for these older python versions.
13 tasks
Contributor
|
FWIW: another similar one #207829 |
bjornfor
pushed a commit
that referenced
this pull request
Dec 26, 2022
Building python.pkgs.shiboken2 fails for python version older than 3.9, due to crypt.h header issue related to older glibc (#202262). The fix is to use libxrypto for these older python versions.
bjornfor
pushed a commit
that referenced
this pull request
Dec 26, 2022
Building python.pkgs.pyside2 fails for python version older than 3.9, due to crypt.h header issue related to older glibc (#202262). The fix is to use libxrypto for these older python versions.
mweinelt
reviewed
Mar 10, 2023
Member
|
Looks like this is still required and I missed reviewing it, sorry. Can you apply the fix and rebase? |
Co-authored-by: Martin Weinelt <mweinelt@users.noreply.github.com>
alcarney
force-pushed
the
python38-pydantic-libxcrypt
branch
from
48cad2e to
dd3185a
Compare
Contributor
Author
|
No worries, that should be done now :) |
Member
|
Where do we still require python 3.8? |
Member
|
We still provide it, that's all that's required to accept a fix. |
Member
|
We don't recurse into 3.8 anymore which I always thought indicates that the package sets are no longer actively maintained. |
Janik-Haag
added
the
12.first-time contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Trying to build pydantic under Python 3.8 fails with a number of errors of the form
which looks like a similar issue to #198036.
Copying the fix in #198045 seems to resolve the issue.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes