buildRustPackage: remove git from nativeBuildInputs

[Atemu]

Having git in nativeBuildInputs causes thousands of rebuilds when git is touched because every derivation that somehow transiently depends on a rust package will change. See #205682 for instance.

AFAICT git is unused. Only the fetcher needs git which it has already.

Fixes #205804

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[raphaelr]

The git in the function parameters can be removed as well.

[Atemu]

Indeed. The previous version I was looking at still passed git through to the fetcher.

[raphaelr]

error: anonymous function at /home/raphi/nixpkgs/pkgs/build-support/rust/build-rust-package/default.nix:1:1 called with unexpected
argument 'git'

       at /home/raphi/nixpkgs/lib/customisation.nix:72:16:

           71|     let
           72|       result = f origArgs;
             |                ^
           73|
       Did you mean lib?

Need to remove this line form make-rust-platform.nix

[samuela]

looks like there's an unrelated change to wandb in this PR as well. i'd recommend rebasing now that #205898 has landed

[Atemu]

I think what happened is that I rebased on top of master thinking that would resolve the merge conflict but the conflicting change was actually on staging, so I rebased on top of that. However, staging didn't have all of master's commits merged in yet, so those other commits from master were also rebased on top of staging. Urgh.

Continued in #206195