Skip to content

doctest 0.20.1 is unbroken #196627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
9999years wants to merge 1 commit into from
Closed

doctest 0.20.1 is unbroken #196627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions pkgs/development/haskell-modules/configuration-ghc-9.4.x.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ in

with haskellLib;
self: super: let
doctest_0_20_broken = p: checkAgainAfter self.doctest "0.20.0" "doctest broken on 9.4" (dontCheck p);
jailbreakForCurrentVersion = p: v: checkAgainAfter p v "bad bounds" (doJailbreak p);
in {
llvmPackages = lib.dontRecurseIntoAttrs self.ghc.llvmPackages;
Expand Down Expand Up @@ -82,21 +81,9 @@ in {
(dontCheck super.cabal2nix);
cabal2nix-unstable = dontCheck super.cabal2nix-unstable;

# build fails on due to ghc api changes
# unfinished PR that doesn't yet compile:
# https://github.com/sol/doctest/pull/375
doctest = markBroken super.doctest_0_20_0;
# consequences of doctest breakage follow:
http-types = doctest_0_20_broken super.http-types;
iproute = doctest_0_20_broken super.iproute;
foldl = doctest_0_20_broken super.foldl;
prettyprinter-ansi-terminal = doctest_0_20_broken super.prettyprinter-ansi-terminal;
pretty-simple = doctest_0_20_broken super.pretty-simple;
http-date = doctest_0_20_broken super.http-date;
network-byte-order = doctest_0_20_broken super.network-byte-order;
co-log-core = doctest_0_20_broken (doJailbreak super.co-log-core);
xml-conduit = doctest_0_20_broken (dontCheck super.xml-conduit);
validation-selective = doctest_0_20_broken (dontCheck super.validation-selective);
co-log-core = doJailbreak super.co-log-core;
xml-conduit = dontCheck super.xml-conduit;
validation-selective = dontCheck super.validation-selective;
Copy link
Member

@sternenseemann sternenseemann Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dontChecks were added to avoid depending on doctest, now that it is unbroken we should reenable tests and check if they can now be executed properly.


double-conversion = markBroken super.double-conversion;
blaze-textual = checkAgainAfter super.double-conversion "2.0.4.1" "double-conversion fails to build; required for testsuite" (dontCheck super.blaze-textual);
Expand All @@ -114,7 +101,7 @@ in {
# Jailbreaks & Version Updates

aeson = self.aeson_2_1_1_0;
aeson-diff = doctest_0_20_broken (dontCheck super.aeson-diff);
aeson-diff = dontCheck super.aeson-diff;
lens-aeson = self.lens-aeson_1_2_2;

assoc = doJailbreak super.assoc;
Expand Down Expand Up @@ -153,7 +140,7 @@ in {

# 2022-09-02: Too strict bounds on lens
# https://github.com/GetShopTV/swagger2/pull/242
swagger2 = doctest_0_20_broken (dontCheck (doJailbreak super.swagger2));
swagger2 = dontCheck (doJailbreak super.swagger2);

base-orphans = dontCheck super.base-orphans;

Expand Down