doctest 0.20.1 is unbroken

[9999years]

Description of changes

Not sure how to actually get doctest 0.20.1 in, but I'm getting an error trying to use it downstream.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[sternenseemann]

These dontChecks were added to avoid depending on doctest, now that it is unbroken we should reenable tests and check if they can now be executed properly.

[sternenseemann]

We'll get doctest 0.20.1 on the next regular hackage bump after which I'd be happy to merge this PR into haskell-updates. Until then you'll have to undo the stale overrides yourself.

[9999years]

We'll get doctest 0.20.1 on the next regular hackage bump after which I'd be happy to merge this PR into haskell-updates. Until then you'll have to undo the stale overrides yourself.

Is there a way to do this without forking nixpkgs?

[sternenseemann]

Reversing changes to derivations is hard, but you can replace the entire compiler specific overlay if you want to:

haskell.packages.ghc942.override {
  compilerConfig = { pkgs, haskellLib }: self: super: {};
}

What you probably want to do is reuse the existing overlay and remove stuff you don't want:

pkgs.haskell.packages.ghc942.override {
  compilerConfig = { pkgs, haskellLib }@args: self: super:
    builtins.removeAttrs (
      import (pkgs.path + "/pkgs/development/haskell-modules/configuration-ghc-9.4.x.nix") args self super
    ) [ "override-I-don't-like" ];
}

[sternenseemann]

Done in 26ec809.