Skip to content

linux/kernel: backport symbol GPLification fix from 5.19 so NixOS installer can build#192668

Merged
Mindavi merged 1 commit intomasterfrom
unknown repository
Jan 6, 2023
Merged

linux/kernel: backport symbol GPLification fix from 5.19 so NixOS installer can build#192668
Mindavi merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Sep 23, 2022

This commit is required in order to build the NixOS installer for PowerPC64.

Description of changes

Linux has a few PowerPC-specific symbols which are marked as GPL exports; these
symbols wound up being exposed in Linux 5.12 and are needed by OpenZFS. The
symbol licensing was fixed in mainline 5.19; this commit backports the fix to
all previous affected kernels.

Things done
  • Built on platform(s)
    • powerpc64le-linux
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: kernel The Linux kernel label Sep 23, 2022
Linux has a few PowerPC-specific symbols which are marked as GPL exports; these
symbols wound up being exposed in Linux 5.12 and are needed by OpenZFS.  The
symbol licensing was fixed in mainline 5.19; this commit backports the fix to
all previous affected kernels.

This commit is required in order to build the NixOS ISO for PowerPC64.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 23, 2022
@ghost ghost mentioned this pull request Sep 23, 2022
3 tasks
@ghost ghost changed the title linux/kernel: backport symbol GPLification fix from 5.19 so ISO can build linux/kernel: backport symbol GPLification fix from 5.19 so NixOS installer can build Sep 26, 2022
@alyssais
Copy link
Member

We have 6.0 now — do we still need this?

@ghost
Copy link
Author

ghost commented Oct 26, 2022

We have 6.0 now — do we still need this?

Unfortunately linux-kernels.nix still sets linux_default = packages.linux_5_15, so that's what the installer uses.

@ghost ghost mentioned this pull request Jan 5, 2023
2 tasks
@ghost
Copy link
Author

ghost commented Jan 5, 2023

Still needed.

@Mindavi
Copy link
Contributor

Mindavi commented Jan 6, 2023

Seems fine to me.

@Mindavi Mindavi merged commit 88e3209 into NixOS:master Jan 6, 2023
@ghost ghost deleted the junk/tryiso branch January 23, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: kernel The Linux kernel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments