llvm3.9: Remove -DCMAKE_BUILD_TYPE=Release flags#19131
Merged
Mic92 merged 1 commit intoNixOS:stagingfrom Oct 3, 2016
Merged
Conversation
|
@aneeshusa, thanks for your PR! By analyzing the annotation information on this pull request, we identified @gebner and @vcunat to be potential reviewers |
rasendubi
added
0.kind: enhancement
rasendubi
approved these changes
Oct 1, 2016
Contributor
Author
|
Oops, didn't realize this was a mass-rebuild for Darwin. Happy to change this to |
Member
|
Looks good to me I think it should be merged into staging as it affects clang and thus causes mass darwin rebuild. |
Since commit 183d05a in 2012, this is the default.
aneeshusa
force-pushed
the
remove-redundant-cmake-build-type-release-args-part2
branch
from
77b3986 to
c04e46c
Compare
Contributor
Author
|
I thought GitHub would be smarter about changing the branch, but it threw in a bunch of extra commits so I rebased this to just the one. |
Member
|
Thanks. |
aneeshusa
deleted the
remove-redundant-cmake-build-type-release-args-part2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
LLVM 3.9 seems to have gotten added after I made the previous PR #18000.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Since commit 183d05a in 2012, this is the default.
cc @Mic92