Remove redundant -DCMAKE_BUILD_TYPE=Release flags

[aneeshusa]

Motivation for this change

Cleanup I noticed while working on #17886.

Things done

• Tested using sandboxing
  (nix.useChroot on NixOS,
  or option build-use-chroot in nix.conf
  on non-NixOS)
• Built on platform(s)
  • NixOS
  • OS X
  • Linux
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

Haven't built or tested yet.

[mention-bot]

@aneeshusa, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Ralith, @edolstra and @andrewrk to be potential reviewers

[andrewrk]

Why is this flag redundant? AFAIK, the default cmake build is not Release.

[aneeshusa]

@andrewrk In pkgs/development/tools/build-managers/cmake/setup-hook.sh, -DCMAKE_BUILD_TYPE=Release is prepended to cmakeFlags, since a commit in 2012. AFAIK, this sets the default to Release (for derivations with cmake as a build input).

[andrewrk]

OK this sounds reasonable to me then.

[aneeshusa]

@andrewrk I updated the commit message with that info, thanks for pointing that out.

[Mic92]

Merged thanks!