Perl: disable tests that involve networking#1905
Perl: disable tests that involve networking#1905pjotrp wants to merge 2 commits intoNixOS:masterfrom
Conversation
|
Looks more sensible than #1632 |
I rebased the branch not to include newer changes from master.
|
Yes, I'm adding this to my choice of simple stdenv-changing improvements proposed to be merged soon. vcunat/nixpkgs@NixOS:glibc-2.19...p/stdenv |
I rebased the branch not to include newer changes from master.
|
@vcunat This should be fixed now, right? |
|
Yes, it's in master already, only github doesn't accept the merge keyword, I guess. |
I rebased the branch not to include newer changes from master.
|
The patch is still not in master, that I can tell. Why is that? Should I send a patch to the ML? |
|
Here's when it was included: 1046b4cca Even github claims it's in master now (if you click the commit, it shows a list of branches including it), and I verified that the two now lines are still present in master. |
|
Note that I got rid of the Perl tests altogether: f95196a |
|
Well, I don't know how much the tests can reveal. However, stdenv isn't rebuilt so often, and for me it's roughly 2-3 hours (a single cheap machine). |
|
My mistake, sorry. git confusion can sometimes kicks in. All hunky dory now.Thanks! And +1 for removing all the Perl tests. |
Janik-Haag
added
the
12.first-time contribution
6 participants
These tests fail on my setup - building in user land on a SARA cluster node