Skip to content

No Net::Ping test in building perl-5.16.3#1632

Closed
wavewave wants to merge 9 commits intoNixOS:masterfrom
wavewave:perl-no-ping
Closed

No Net::Ping test in building perl-5.16.3#1632
wavewave wants to merge 9 commits intoNixOS:masterfrom
wavewave:perl-no-ping

Conversation

@wavewave
Copy link
Contributor

Due to some firewall restriction, Net::Ping tests while buiding perl caused failure with the following error:

Failed 6 tests out of 2173, 99.72% okay.
    ../dist/Net-Ping/t/120_udp_inst.t
    ../dist/Net-Ping/t/130_tcp_inst.t
    ../dist/Net-Ping/t/140_stream_inst.t
    ../dist/Net-Ping/t/150_syn_inst.t
    ../dist/Net-Ping/t/450_service.t
    ../dist/Net-Ping/t/510_ping_udp.t
### Since not all tests were successful, you may want to run some of
### them individually and examine any diagnostic messages they produce.
### See the INSTALL document's section on "make test".

This patch removes Net-Ping tests from perl source code base.

@wavewave
Copy link
Contributor Author

Please ignore poppler-glib patch in the above. Only the last one is relevant. Sorry for confusion.

@vcunat
Copy link
Member

vcunat commented Jan 30, 2014

Hmm, builders aren't supposed to access network, and in chroot builds it even isn't possible, which is what we're doing for Linux builds on Hydra. I wonder why the tests are skipped there and not for you.

dist/Net-Ping/t/100_load ...................................... ok
dist/Net-Ping/t/110_icmp_inst ................................. ok
dist/Net-Ping/t/120_udp_inst .................................. skipped
dist/Net-Ping/t/130_tcp_inst .................................. skipped
dist/Net-Ping/t/140_stream_inst ............................... skipped
dist/Net-Ping/t/150_syn_inst .................................. skipped
dist/Net-Ping/t/190_alarm ..................................... skipped
dist/Net-Ping/t/200_ping_tcp .................................. skipped
dist/Net-Ping/t/250_ping_hires ................................ skipped
dist/Net-Ping/t/300_ping_stream ............................... skipped
dist/Net-Ping/t/400_ping_syn .................................. skipped
dist/Net-Ping/t/410_syn_host .................................. skipped
dist/Net-Ping/t/450_service ................................... skipped
dist/Net-Ping/t/500_ping_icmp ................................. ok
dist/Net-Ping/t/510_ping_udp .................................. skipped

@vcunat
Copy link
Member

vcunat commented Jan 30, 2014

Removing the test should do no harm, as we don't want to run it anyway. For testing/merging workflow, this is the same problem as #1633 (perl is inevitably stdenv-changing).

@wavewave
Copy link
Contributor Author

Hmm, that's interesting. I thought it was due to the firewall as the name of the module (Net::Ping) suggested. I was testing this on AFS workspace on my machine which has a very strict firewall and SELinux. I am going to investigate errors further if I can have more information from verbose logs.

@shlevy
Copy link
Member

shlevy commented Mar 15, 2014

This appears to be subsumed by #1905, which will be merged soon as part of a series of stdenv changes. Please feel free to reopen if this is not covered by that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants