Skip to content

haskellPackages.keid-render-basic: Fix missing build tool#189445

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
dpwiz:haskell-updates
Sep 2, 2022
Merged

haskellPackages.keid-render-basic: Fix missing build tool#189445
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
dpwiz:haskell-updates

Conversation

@dpwiz
Copy link
Contributor

@dpwiz dpwiz commented Sep 2, 2022

Description of changes

glslangValidator tool from glslang package is required to build the package.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Sep 2, 2022
@dpwiz dpwiz marked this pull request as ready for review September 2, 2022 11:49
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 2, 2022
@cdepillabout
Copy link
Member

Built for me, thanks!

@cdepillabout cdepillabout merged commit 010da5a into NixOS:haskell-updates Sep 2, 2022
@cdepillabout
Copy link
Member

In the future, you can feel free to also run ./maintainers/scripts/haskell/regenerate-hackage-packages.sh to actually mark the package as unbroken. That makes it a little easier for the maintainers, since we then don't have to run it ourselves. No big deal though.

@dpwiz dpwiz deleted the haskell-updates branch September 3, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants