Skip to content

haskellPackages.keid-render-basic: Fix missing build tool#189438

Closed
dpwiz wants to merge 1 commit intoNixOS:masterfrom
dpwiz:master
Closed

haskellPackages.keid-render-basic: Fix missing build tool#189438
dpwiz wants to merge 1 commit intoNixOS:masterfrom
dpwiz:master

Conversation

@dpwiz
Copy link
Contributor

@dpwiz dpwiz commented Sep 2, 2022

Description of changes

Add missing build tool from pkgs.glslang.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Sep 2, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 2, 2022
@dpwiz dpwiz marked this pull request as ready for review September 2, 2022 11:21
@dpwiz dpwiz changed the title Fix haskell-modules.keid-render-basic haskellPackages.keid-render-basic: Fix missing build tool Sep 2, 2022
@cdepillabout
Copy link
Member

@dpwiz Thanks for sending this!

We generally try to send all Haskell-related PRs to the haskell-updates branch. Would be able to rebase onto there?

Other than that, this LGTM.

@dpwiz
Copy link
Contributor Author

dpwiz commented Sep 2, 2022

Redid this with haskell-updates in #189445

@dpwiz dpwiz closed this Sep 2, 2022
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants