nvidia_x11: reorganize latest versions by Kiskae · Pull Request #186834 · NixOS/nixpkgs

Kiskae · 2022-08-15T19:09:50Z

Description of changes

nvidia appears to not update packages if there is a package with a higher maturity (long-lived-branch-release > official > beta) and a higher version. At the moment the "beta" and "new feature branch" branches aren't actively in use, so only the "production" is getting updates, superceding the other branches.
- Add nvidia_x11_production kernelPackages alias so all 3 versions are represented
- Unbreak the open-kernel builds for linux 5.19 and linked its broken flag to the proprietary build, since they share kernel glue code.
Add a warning on the nvidia_x11 -> nvidia_x11_legacy390 alias for x86 and change the nvidia.package default to use nvidia_x11_legacy390 on i686-linux. Handling the alternatives in the nixos configuration seems a lot cleaner and by just adding a warning we avoid breaking configurations that explicitly select nvidia_x11.

Things done

Kiskae · 2022-08-15T20:10:44Z

1 package marked as broken and skipped:
linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_beta_open

1 package blacklisted:
nixos-install-tools

2 packages failed to build:
linuxKernel.packages.linux_5_4_hardened.nvidia_x11_beta_open linuxKernel.packages.linux_latest_libre.nvidia_x11_beta_open

19 packages built:
linuxKernel.packages.linux_4_14.nvidia_x11_beta_open linuxKernel.packages.linux_4_14_hardened.nvidia_x11_beta_open linuxKernel.packages.linux_4_19.nvidia_x11_beta_open linuxKernel.packages.linux_4_19_hardened.nvidia_x11_beta_open linuxKernel.packages.linux_4_9.nvidia_x11_beta_open linuxKernel.packages.linux_5_10.nvidia_x11_beta_open linuxKernel.packages.linux_5_10_hardened.nvidia_x11_beta_open linuxKernel.packages.linux_5_15.nvidia_x11_beta_open linuxKernel.packages.linux_hardened.nvidia_x11_beta_open linuxKernel.packages.linux_5_18.nvidia_x11_beta_open linuxKernel.packages.linux_5_18_hardened.nvidia_x11_beta_open linuxKernel.packages.linux_5_19.nvidia_x11_beta_open linuxKernel.packages.linux_5_4.nvidia_x11_beta_open linuxKernel.packages.linux_libre.nvidia_x11_beta_open linuxKernel.packages.linux_lqx.nvidia_x11_beta_open linuxKernel.packages.linux_xanmod.nvidia_x11_beta_open linuxKernel.packages.linux_xanmod_latest.nvidia_x11_beta_open linuxKernel.packages.linux_xanmod_tt.nvidia_x11_beta_open linuxKernel.packages.linux_zen.nvidia_x11_beta_open

Ping @PedroHLC @superherointj

Kiskae · 2022-08-15T20:12:58Z

So I was puzzled why the nvidia_x11 warning was being triggered on x86_64, but it is probably because the pkgsi686Linux package set is also getting recursively evaluated. I am not entirely sure how to fix this.

PedroHLC

The code looks good, the approach is exactly what I had in mind.

But, before approving, I'll run some tests.

PedroHLC · 2022-08-15T22:42:11Z

Result of nixpkgs-review pr 186834 run on x86_64-linux 1

1 package marked as broken and skipped:

linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_beta_open

1 package blacklisted:

nixos-install-tools

2 packages failed to build:

linuxKernel.packages.linux_5_4_hardened.nvidia_x11_beta_open
linuxKernel.packages.linux_latest_libre.nvidia_x11_beta_open

19 packages built:

linuxKernel.packages.linux_4_14.nvidia_x11_beta_open
linuxKernel.packages.linux_4_14_hardened.nvidia_x11_beta_open
linuxKernel.packages.linux_4_19.nvidia_x11_beta_open
linuxKernel.packages.linux_4_19_hardened.nvidia_x11_beta_open
linuxKernel.packages.linux_4_9.nvidia_x11_beta_open
linuxKernel.packages.linux_5_10.nvidia_x11_beta_open
linuxKernel.packages.linux_5_10_hardened.nvidia_x11_beta_open
linuxKernel.packages.linux_5_15.nvidia_x11_beta_open
linuxKernel.packages.linux_hardened.nvidia_x11_beta_open (linuxKernel.packages.linux_5_15_hardened.nvidia_x11_beta_open)
linuxKernel.packages.linux_5_18.nvidia_x11_beta_open
linuxKernel.packages.linux_5_18_hardened.nvidia_x11_beta_open
linuxKernel.packages.linux_5_19.nvidia_x11_beta_open
linuxKernel.packages.linux_5_4.nvidia_x11_beta_open
linuxKernel.packages.linux_libre.nvidia_x11_beta_open
linuxKernel.packages.linux_lqx.nvidia_x11_beta_open
linuxKernel.packages.linux_xanmod.nvidia_x11_beta_open
linuxKernel.packages.linux_xanmod_latest.nvidia_x11_beta_open
linuxKernel.packages.linux_xanmod_tt.nvidia_x11_beta_open
linuxKernel.packages.linux_zen.nvidia_x11_beta_open

PedroHLC

linuxKernel.packages.linux_5_19.nvidia_x11 builds nvidia-x11-515.65.01-5.19;
linuxKernel.packages.linux_5_19.nvidia_x11_beta re-uses nvidia-x11-515.65.01-5.19;
linuxKernel.packages.linux_5_19.nvidia_x11_production re-uses nvidia-x11-515.65.01-5.19;
linuxKernel.packages.linux_5_19.nvidia_x11_vulkan_beta evaluates to the nvidia-x11-470.62.13-5.19, which is marked as broken;
Changing the beta version to a fake 515.90.04, with random sha256, makes linuxKernel.packages.linux_5_19.nvidia_x11_beta try to build it.

superherointj · 2022-08-17T12:43:29Z

ofborg-eval is failing:
https://gist.github.com/be5d57406e5e3381c3be2c3b34af7b1c

nix-env did not evaluate cleanly:
 ["trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86", "trace: warning: Prefer 'nvidia_x11_legacy390' over the 'nvidia_x11' alias on x86"]

Kiskae · 2022-08-17T12:58:56Z

pkgs/os-specific/linux/nvidia-x11/default.nix

Even if we filter for i686-linux I believe it will still be triggered because the pkgsi686Linux package set is also evaluated on x86_64-linux and includes whatever we return here.

I'm wondering if we should just remove the alias. Since the nixos module change will handle anyone who relied on the defaults, this would only affect those on i686 that explicitly set the package to nvidia_x11 which would've been redundant before this change.

nixos/modules/hardware/video/nvidia.nix

pkgs/os-specific/linux/nvidia-x11/default.nix

Kiskae · 2022-08-17T13:16:22Z

So I've done some digging for the origin of the stable -> legacy_390 alias, apparently it was originally there because the stable branch was an explicit other option.
This was changed in #73167 and I'm not exactly sure why.

I propose reverting my changes to the stable alias and instead introduce a latest package that acts as the "New Feature Branch" version of the driver, leaving stable as just an alias.

superherointj · 2022-08-17T13:19:18Z

I propose reverting my changes to the stable alias and instead introduce a latest package that acts as the "New Feature Branch" version of the driver, leaving stable as just an alias.

Would default package be set to latest?

Kiskae · 2022-08-17T13:20:03Z

It would be set to stable, which on x86_64 aliases to latest

Kiskae · 2022-08-17T13:33:22Z

@PedroHLC is there much value in being able to use a specific branch if NVIDIA only supports a subset of them:
https://raw.githubusercontent.com/aaronp24/nvidia-versions/master/nvidia-versions.txt

While the legacy branches have static versions, the current branch can change their branch number at any time and people generally expect it to update automatically.

pkgs/os-specific/linux/nvidia-x11/default.nix

PedroHLC · 2022-08-17T13:37:44Z

@PedroHLC is there much value in being able to use a specific branch if NVIDIA only supports a subset of them: https://raw.githubusercontent.com/aaronp24/nvidia-versions/master/nvidia-versions.txt

While the legacy branches have static versions, the current branch can change their branch number at any time and people generally expect it to update automatically.

🤔 I get it, let's do what you proposed (add the latest, revert the changes to the other ones), in another PR I can add the 495, 510 and 515 as standalone packages, making production/stable/beta point to them instead of being the only source to these packages.

pkgs/os-specific/linux/nvidia-x11/default.nix

superherointj · 2022-08-17T13:47:25Z

Please squash commits.

nvidia_x11_open: unbreak 5.19 common kernel code is shared, if the closed build is broken, so is the open one. nvidia_x11_production: add alias, sort names nvidia_x11: reintroduce stable as a pure alias nvidia_x11: don't use alias in override

superherointj · 2022-08-17T14:55:08Z

Result of nixpkgs-review pr 186834 run on x86_64-linux 1

1 package marked as broken and skipped:

linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_beta_open

13 packages failed to build:

linuxKernel.packages.linux_5_10.nvidia_x11_beta_open
linuxKernel.packages.linux_5_10_hardened.nvidia_x11_beta_open
linuxKernel.packages.linux_5_15.nvidia_x11_beta_open
linuxKernel.packages.linux_hardened.nvidia_x11_beta_open (linuxKernel.packages.linux_5_15_hardened.nvidia_x11_beta_open)
linuxKernel.packages.linux_5_18.nvidia_x11_beta_open
linuxKernel.packages.linux_5_18_hardened.nvidia_x11_beta_open
linuxKernel.packages.linux_5_19.nvidia_x11_beta_open
linuxKernel.packages.linux_5_4.nvidia_x11_beta_open
linuxKernel.packages.linux_5_4_hardened.nvidia_x11_beta_open
linuxKernel.packages.linux_latest_libre.nvidia_x11_beta_open
linuxKernel.packages.linux_libre.nvidia_x11_beta_open
linuxKernel.packages.linux_xanmod.nvidia_x11_beta_open
linuxKernel.packages.linux_xanmod_latest.nvidia_x11_beta_open

8 packages built:

linuxKernel.packages.linux_4_14.nvidia_x11_beta_open
linuxKernel.packages.linux_4_14_hardened.nvidia_x11_beta_open
linuxKernel.packages.linux_4_19.nvidia_x11_beta_open
linuxKernel.packages.linux_4_19_hardened.nvidia_x11_beta_open
linuxKernel.packages.linux_4_9.nvidia_x11_beta_open
linuxKernel.packages.linux_lqx.nvidia_x11_beta_open
linuxKernel.packages.linux_xanmod_tt.nvidia_x11_beta_open
linuxKernel.packages.linux_zen.nvidia_x11_beta_open

superherointj · 2022-08-17T15:00:34Z

@Kiskae Please notice the failed packages on my build.

Kiskae · 2022-08-17T17:21:57Z

@superherointj It looks like all the failed builds are for linux kernels that just got updated. I checked the builds against the version of master this is forked from and they build just fine. Currently compiling the new kernels to check but it would be a weird coincidence that they all failed at once.

Kiskae · 2022-08-18T07:15:17Z

4 packages failed to build:
linuxPackages_5_4_hardened.nvidia_x11_beta linuxPackages_5_4_hardened.nvidia_x11_beta_open linuxPackages_latest-libre.nvidia_x11_beta linuxPackages_latest-libre.nvidia_x11_beta_open

38 packages built:

Looks like it is a transient problem with linux kernels that aren't in the binary cache yet, unrelated to this PR.

superherointj · 2022-08-18T10:07:46Z

Result of nixpkgs-review pr 186834 run on x86_64-linux 1

12 packages marked as broken and skipped:

linuxKernel.packages.hardkernel_4_14.nvidia_x11_beta
linuxKernel.packages.hardkernel_4_14.nvidia_x11_beta_open
linuxKernel.packages.hardkernel_4_14.nvidia_x11_production
linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_beta
linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_beta_open
linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_production
linuxPackages_hardkernel_latest.nvidia_x11_beta
linuxPackages_hardkernel_latest.nvidia_x11_beta_open
linuxPackages_hardkernel_latest.nvidia_x11_production
linuxPackages_testing_bcachefs.nvidia_x11_beta
linuxPackages_testing_bcachefs.nvidia_x11_beta_open
linuxPackages_testing_bcachefs.nvidia_x11_production

4 packages failed to build:

linuxPackages_5_4_hardened.nvidia_x11_beta (linuxKernel.packages.linux_5_4_hardened.nvidia_x11_beta ,linuxPackages_5_4_hardened.nvidia_x11_production)
linuxPackages_5_4_hardened.nvidia_x11_beta_open (linuxKernel.packages.linux_5_4_hardened.nvidia_x11_beta_open)
linuxPackages_latest-libre.nvidia_x11_beta (linuxKernel.packages.linux_latest_libre.nvidia_x11_beta ,linuxPackages_latest-libre.nvidia_x11_production)
linuxPackages_latest-libre.nvidia_x11_beta_open (linuxKernel.packages.linux_latest_libre.nvidia_x11_beta_open)

38 packages built:

linuxKernel.packages.linux_4_14.nvidia_x11_beta (linuxKernel.packages.linux_4_14.nvidia_x11_production)
linuxKernel.packages.linux_4_14.nvidia_x11_beta_open
linuxPackages_4_14_hardened.nvidia_x11_beta (linuxKernel.packages.linux_4_14_hardened.nvidia_x11_beta ,linuxPackages_4_14_hardened.nvidia_x11_production)
linuxPackages_4_14_hardened.nvidia_x11_beta_open (linuxKernel.packages.linux_4_14_hardened.nvidia_x11_beta_open)
linuxKernel.packages.linux_4_19.nvidia_x11_beta (linuxKernel.packages.linux_4_19.nvidia_x11_production)
linuxKernel.packages.linux_4_19.nvidia_x11_beta_open
linuxPackages_4_19_hardened.nvidia_x11_beta (linuxKernel.packages.linux_4_19_hardened.nvidia_x11_beta ,linuxPackages_4_19_hardened.nvidia_x11_production)
linuxPackages_4_19_hardened.nvidia_x11_beta_open (linuxKernel.packages.linux_4_19_hardened.nvidia_x11_beta_open)
linuxKernel.packages.linux_4_9.nvidia_x11_beta (linuxKernel.packages.linux_4_9.nvidia_x11_production)
linuxKernel.packages.linux_4_9.nvidia_x11_beta_open
linuxKernel.packages.linux_5_10.nvidia_x11_beta (linuxKernel.packages.linux_5_10.nvidia_x11_production)
linuxKernel.packages.linux_5_10.nvidia_x11_beta_open
linuxPackages_5_10_hardened.nvidia_x11_beta (linuxKernel.packages.linux_5_10_hardened.nvidia_x11_beta ,linuxPackages_5_10_hardened.nvidia_x11_production)
linuxPackages_5_10_hardened.nvidia_x11_beta_open (linuxKernel.packages.linux_5_10_hardened.nvidia_x11_beta_open)
linuxPackages.nvidia_x11_beta (linuxKernel.packages.linux_5_15.nvidia_x11_beta ,linuxPackages.nvidia_x11_production)
linuxPackages.nvidia_x11_beta_open (linuxKernel.packages.linux_5_15.nvidia_x11_beta_open)
linuxPackages_hardened.nvidia_x11_beta (linuxPackages_5_15_hardened.nvidia_x11_beta ,linuxPackages_hardened.nvidia_x11_production)
linuxPackages_hardened.nvidia_x11_beta_open (linuxPackages_5_15_hardened.nvidia_x11_beta_open)
linuxKernel.packages.linux_5_18.nvidia_x11_beta (linuxKernel.packages.linux_5_18.nvidia_x11_production)
linuxKernel.packages.linux_5_18.nvidia_x11_beta_open
linuxPackages_5_18_hardened.nvidia_x11_beta (linuxKernel.packages.linux_5_18_hardened.nvidia_x11_beta ,linuxPackages_5_18_hardened.nvidia_x11_production)
linuxPackages_5_18_hardened.nvidia_x11_beta_open (linuxKernel.packages.linux_5_18_hardened.nvidia_x11_beta_open)
linuxPackages_latest.nvidia_x11_beta (linuxKernel.packages.linux_5_19.nvidia_x11_beta ,linuxPackages_latest.nvidia_x11_production)
linuxPackages_latest.nvidia_x11_beta_open (linuxKernel.packages.linux_5_19.nvidia_x11_beta_open)
linuxKernel.packages.linux_5_4.nvidia_x11_beta (linuxKernel.packages.linux_5_4.nvidia_x11_production)
linuxKernel.packages.linux_5_4.nvidia_x11_beta_open
linuxPackages-libre.nvidia_x11_beta (linuxKernel.packages.linux_libre.nvidia_x11_beta ,linuxPackages-libre.nvidia_x11_production)
linuxPackages-libre.nvidia_x11_beta_open (linuxKernel.packages.linux_libre.nvidia_x11_beta_open)
linuxPackages_lqx.nvidia_x11_beta (linuxKernel.packages.linux_lqx.nvidia_x11_beta ,linuxPackages_lqx.nvidia_x11_production)
linuxPackages_lqx.nvidia_x11_beta_open (linuxKernel.packages.linux_lqx.nvidia_x11_beta_open)
linuxPackages_xanmod.nvidia_x11_beta (linuxKernel.packages.linux_xanmod.nvidia_x11_beta ,linuxPackages_xanmod.nvidia_x11_production)
linuxPackages_xanmod.nvidia_x11_beta_open (linuxKernel.packages.linux_xanmod.nvidia_x11_beta_open)
linuxPackages_xanmod_latest.nvidia_x11_beta (linuxKernel.packages.linux_xanmod_latest.nvidia_x11_beta ,linuxPackages_xanmod_latest.nvidia_x11_production)
linuxPackages_xanmod_latest.nvidia_x11_beta_open (linuxKernel.packages.linux_xanmod_latest.nvidia_x11_beta_open)
linuxPackages_xanmod_tt.nvidia_x11_beta (linuxKernel.packages.linux_xanmod_tt.nvidia_x11_beta ,linuxPackages_xanmod_tt.nvidia_x11_production)
linuxPackages_xanmod_tt.nvidia_x11_beta_open (linuxKernel.packages.linux_xanmod_tt.nvidia_x11_beta_open)
linuxPackages_zen.nvidia_x11_beta (linuxKernel.packages.linux_zen.nvidia_x11_beta ,linuxPackages_zen.nvidia_x11_production)
linuxPackages_zen.nvidia_x11_beta_open (linuxKernel.packages.linux_zen.nvidia_x11_beta_open)

nixos-discourse · 2023-08-02T13:35:28Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nvidia-driver-attributes-dont-do-anything/31190/2

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 15, 2022

Kiskae force-pushed the nvidia-branches branch from a6e9cac to 37daadc Compare August 15, 2022 19:12

superherointj requested a review from PedroHLC August 15, 2022 20:15

PedroHLC reviewed Aug 15, 2022

View reviewed changes

PedroHLC approved these changes Aug 15, 2022

View reviewed changes

PedroHLC requested a review from superherointj August 15, 2022 22:51

bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 16, 2022

Kiskae commented Aug 17, 2022

View reviewed changes

superherointj reviewed Aug 17, 2022

View reviewed changes

nixos/modules/hardware/video/nvidia.nix Outdated Show resolved Hide resolved

superherointj reviewed Aug 17, 2022

View reviewed changes

pkgs/os-specific/linux/nvidia-x11/default.nix Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

Kiskae force-pushed the nvidia-branches branch from 37daadc to 1bed3e7 Compare August 17, 2022 13:33

github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 17, 2022

Kiskae force-pushed the nvidia-branches branch from 1bed3e7 to a9b20f5 Compare August 17, 2022 13:36

superherointj reviewed Aug 17, 2022

View reviewed changes

pkgs/os-specific/linux/nvidia-x11/default.nix Outdated Show resolved Hide resolved

Kiskae force-pushed the nvidia-branches branch from a9b20f5 to 1e2ffaa Compare August 17, 2022 13:41

PedroHLC approved these changes Aug 17, 2022

View reviewed changes

Kiskae requested review from PedroHLC and removed request for superherointj August 17, 2022 13:42

Kiskae requested a review from superherointj August 17, 2022 13:42

ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 17, 2022

ofborg bot requested review from NickCao and jonringer August 17, 2022 13:45

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Aug 17, 2022

superherointj reviewed Aug 17, 2022

View reviewed changes

pkgs/os-specific/linux/nvidia-x11/default.nix Outdated Show resolved Hide resolved

superherointj reviewed Aug 17, 2022

View reviewed changes

pkgs/os-specific/linux/nvidia-x11/default.nix Outdated Show resolved Hide resolved

superherointj reviewed Aug 17, 2022

View reviewed changes

pkgs/os-specific/linux/nvidia-x11/default.nix Outdated Show resolved Hide resolved

nvidia_x11: add conditional overrides

45e6c60

nvidia_x11_open: unbreak 5.19 common kernel code is shared, if the closed build is broken, so is the open one. nvidia_x11_production: add alias, sort names nvidia_x11: reintroduce stable as a pure alias nvidia_x11: don't use alias in override

Kiskae force-pushed the nvidia-branches branch from 4273217 to 45e6c60 Compare August 17, 2022 13:50

Kiskae requested a review from superherointj August 17, 2022 14:09

superherointj approved these changes Aug 18, 2022

View reviewed changes

superherointj merged commit b01f02f into NixOS:master Aug 18, 2022

Kiskae deleted the nvidia-branches branch August 18, 2022 14:15

Uh oh!

Comments

Conversation

Kiskae commented Aug 15, 2022

Description of changes

Things done

Uh oh!

Kiskae commented Aug 15, 2022

Uh oh!

Kiskae commented Aug 15, 2022

Uh oh!

PedroHLC left a comment

Choose a reason for hiding this comment

Uh oh!

PedroHLC commented Aug 15, 2022

Uh oh!

PedroHLC left a comment

Choose a reason for hiding this comment

Uh oh!

superherointj commented Aug 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kiskae Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Kiskae commented Aug 17, 2022

Uh oh!

superherointj commented Aug 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kiskae commented Aug 17, 2022

Uh oh!

This comment was marked as outdated.

Kiskae commented Aug 17, 2022

Uh oh!

Uh oh!

PedroHLC commented Aug 17, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

superherointj commented Aug 17, 2022

Uh oh!

superherointj commented Aug 17, 2022

Uh oh!

superherointj commented Aug 17, 2022

Uh oh!

Kiskae commented Aug 17, 2022

Uh oh!

Kiskae commented Aug 18, 2022

Uh oh!

superherointj commented Aug 18, 2022

Uh oh!

nixos-discourse commented Aug 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

superherointj commented Aug 17, 2022 •

edited

Loading

superherointj commented Aug 17, 2022 •

edited

Loading