Skip to content

Comments

nvidia-x11-beta: mark broken for linux 5.19#186321

Merged
superherointj merged 1 commit intoNixOS:masterfrom
PedroHLC:nvidia-beta-broken-5.19
Aug 12, 2022
Merged

nvidia-x11-beta: mark broken for linux 5.19#186321
superherointj merged 1 commit intoNixOS:masterfrom
PedroHLC:nvidia-beta-broken-5.19

Conversation

@PedroHLC
Copy link
Member

@PedroHLC PedroHLC commented Aug 12, 2022

Description of changes

Mark nvidia-x11-beta broken for kernel.kernelAtLeast "5.19".

Things done

Upstream kernel: check for linuxPackages_latest.nvidia_x11_beta (linuxKernel.packages.linux_5_19.nvidia_x11_beta) in this comment.

Zen's kernels: check for linuxPackages_zen.nvidia_x11_beta (linuxKernel.packages.linux_zen.nvidia_x11_beta) in this comment.

Xanmod: check for linuxPackages_xanmod_latest.nvidia_x11_beta in this comment


For some reason, I'm unable to mark @Kiskae for reviewing this...

@PedroHLC
Copy link
Member Author

At the moment of this writing, this is the last beta version:
screenshot

@PedroHLC PedroHLC marked this pull request as ready for review August 12, 2022 18:10
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 12, 2022
@PedroHLC PedroHLC force-pushed the nvidia-beta-broken-5.19 branch from 667c838 to 074c21e Compare August 12, 2022 18:20
@PedroHLC PedroHLC requested a review from superherointj August 12, 2022 18:20
Copy link
Contributor

@superherointj superherointj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm linuxKernel.packages.linux_5_19.nvidia_x11_beta is broken.
And linuxKernel.packages.linux_5_18.nvidia_x11_beta builds fine.

@superherointj superherointj merged commit 37b546e into NixOS:master Aug 12, 2022
@PedroHLC PedroHLC deleted the nvidia-beta-broken-5.19 branch August 12, 2022 19:34
@Kiskae
Copy link
Contributor

Kiskae commented Aug 12, 2022

I'm pretty sure nvidia intends for stable releases to supersede beta releases if they are a newer version than the published beta.

When they patched the stable 515.65 branch for linux 5.19 they also patched the old 510.85 branch, but not the beta branch.

@superherointj
Copy link
Contributor

I'm pretty sure nvidia intends for stable releases to supersede beta releases if they are a newer version than the published beta.

When they patched the stable 515.65 branch for linux 5.19 they also patched the old 510.85 branch, but not the beta branch.

As you have better awareness of situation, feel free to propose a PR fixing it. Add me as reviewer.

@PedroHLC
Copy link
Member Author

I'm pretty sure nvidia intends for stable releases to supersede beta releases if they are a newer version than the published beta.

When they patched the stable 515.65 branch for linux 5.19 they also patched the old 510.85 branch, but not the beta branch.

NVIDIA versioning uses branch-minor-patch right? Can we make it so beta = beta.minor > stable.minor ? beta : stable ?

@Kiskae
Copy link
Contributor

Kiskae commented Aug 13, 2022

Based on the comments in https://github.com/aaronp24/nvidia-versions/blob/main/nvidia-versions.txt there are 3 maturity levels on the current development branch.

long-lived-branch-release is the 'production' branch, it never gets superceded.
official is the 'stable' branch, it gets superceded by long-lived-branch-release if that branch has a newer version.
beta is the 'beta' branch, it gets superceded by official if that branch has a newer version.

In addition this superceding happens across major releases, not just minor versions. This can be seen by the fact that the 'official' branch is still stuck on 495.46 but isn't getting linux kernel compatibility patches, while the long-lived-branch-release branch is.

As a side-note it appears the legacy_340 is no longer officially supported by NVIDIA: https://github.com/aaronp24/nvidia-versions/blob/main/NVVersionParser.hs#L22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants