buildGoPackage: deps.json -> deps.nix in NIXON#18487
buildGoPackage: deps.json -> deps.nix in NIXON#18487kamilchm wants to merge 4 commits intoNixOS:masterfrom
Conversation
|
@kamilchm, thanks for your PR! By analyzing the annotation information on this pull request, we identified @zimbatm, @offlinehacker and @rushmorem to be potential reviewers |
|
The packages build fine but it seems like you forgot to update the docs. May I also suggest that we take this opportunity to mention the removal of |
|
Docs updated. |
|
Had opened an issue for the release notes (#18496) but I see you have since added them. Thanks! |
doc/languages-frameworks/go.xml
Outdated
There was a problem hiding this comment.
Is import necessary here? I don't see it included in the packages you converted from deps.json.
47fdc12 to
5c00bad
Compare
doc/languages-frameworks/go.xml
Outdated
There was a problem hiding this comment.
you and me know what NIXON means but not the reader.
The dependency data structure is described below.
|
Looking good! Let me know if you want to change the NIXON references, otherwise I'll just merge it and add it to the 16.09 branch. |
5c00bad to
bffb809
Compare
bffb809 to
ce2ba41
Compare
|
@zimbatm I replaced |
|
Telegraf needs to be converted #18437 |
|
Let me merge this and then update telegraph |
|
Pushed as 914e0e5 on master. I squashed the commits to make it easier to cherry-pick onto the 16.09 branch. |
|
Pushed as 9ab3dc2 on the release-16.09 branch. etcd had to be fixed. |
|
I think everything's good now! Thanks a lot @kamilchm |
Motivation for this change
#17254 (comment)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)