Skip to content

Telegraf#18437

Merged
zimbatm merged 1 commit intoNixOS:masterfrom
Mic92:telegraf
Sep 15, 2016
Merged

Telegraf#18437
zimbatm merged 1 commit intoNixOS:masterfrom
Mic92:telegraf

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 8, 2016

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Mic92, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ragnard and @zimbatm to be potential reviewers

@joachifm
Copy link
Contributor

joachifm commented Sep 8, 2016

See also #18149

@Mic92
Copy link
Member Author

Mic92 commented Sep 8, 2016

mhm. Looks like I was too slow.

Maybe you could take my ruby script addition and update to telegraf 1.0.0

@groxxda
Copy link
Contributor

groxxda commented Sep 8, 2016

You could cherry-pick from the other PR, rebase your changes on top, fix open concerns and force push here 😉

Signed-off-by: Jörg Thalheim <joerg@higgsboson.tk>
@Mic92
Copy link
Member Author

Mic92 commented Sep 14, 2016

now includes all the changes done by @roblabla
but with updated service unit

@Mic92
Copy link
Member Author

Mic92 commented Sep 15, 2016

anything left to do?

@zimbatm zimbatm merged commit 7a6b860 into NixOS:master Sep 15, 2016
@zimbatm
Copy link
Member

zimbatm commented Sep 15, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants