python3Packages.python-lsp-server: fix test issues from 1.5.0 upgrade#184026
Closed
lilyinstarlight wants to merge 2 commits intoNixOS:masterfrom
Closed
python3Packages.python-lsp-server: fix test issues from 1.5.0 upgrade#184026lilyinstarlight wants to merge 2 commits intoNixOS:masterfrom
lilyinstarlight wants to merge 2 commits intoNixOS:masterfrom
Conversation
Changes: * The `test_numpy_completion` test is currently broken - see davidhalter/jedi#1864 * The test flags were moved from setup.cfg to pyproject.toml - see python-lsp/python-lsp-server#207 * A dependency on `whatthepatch` was added for yapf - see python-lsp/python-lsp-server#136
Member
Author
|
Oops I swear I searched this, but I missed #183862 somehow. Closing this PR in favor of that one (sorry about the extra noise) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes issues building
python-lsp-serversince it was bumped to 1.5.0 in #181620 (see hydra build 185438708)Changes:
test_numpy_completiontest is currently broken - see Autocompletion not working for numpy >= 1.22 davidhalter/jedi#1864PEP 621-compliantpyproject.tomlpython-lsp/python-lsp-server#207whatthepatchwas added for yapf - see Parse YAPF diffs into TextEdits (instead of sending the full doc) python-lsp/python-lsp-server#136The package
python3Packages.spyder(which depends on this package) is still failing due to thepython3Packages.qdarkstyleupdate, but that's unrelated to this PR (I might open another PR to fix that one, but I don't personally use it, unlike this one)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notesnixpkgs-review
Result of
nixpkgs-reviewrun on x86_64-linux 12 packages failed to build:
14 packages built: