python3Packages.python-lsp-server: fix build#183862
Merged
kira-bruneau merged 2 commits intoNixOS:masterfrom Aug 3, 2022
jyooru:fix/python3Packages.python-lsp-server
Merged
python3Packages.python-lsp-server: fix build#183862kira-bruneau merged 2 commits intoNixOS:masterfrom jyooru:fix/python3Packages.python-lsp-server
kira-bruneau merged 2 commits intoNixOS:masterfrom
jyooru:fix/python3Packages.python-lsp-server
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 11-100
winterqt
approved these changes
Jul 30, 2022
bobby285271
added
the
12.approvals: 1
13 tasks
Member
There was a problem hiding this comment.
The postPatch section can be removed now, since those lines were moved to pyproject.toml in 1.5.0 (see python-lsp/python-lsp-server#207) but you added pytest-cov anyway which removes the need for those lines afaik
If the --junitxml=pytest.xml and mccabe lines are still relevant, though, setup.cfg should be changed to pyproject.toml on line 55
fabaff
reviewed
Jul 30, 2022
bobby285271
removed
the
12.approvals: 1
Contributor
|
Result of 2 packages failed to build:
14 packages built:
|
kira-bruneau
approved these changes
Aug 3, 2022
Contributor
kira-bruneau
left a comment
kira-bruneau
left a comment
There was a problem hiding this comment.
spyder was already failing due to a bad version requirement, this fix LGTM! ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Failed to load hook pylsp_completions: 'NoneType' object has no attribute 'type'when working with Numpy 1.23 python-lsp/python-lsp-server#243)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes