kmscon: unstable-2018-09-07 -> 9.0.0

[Infinidoge]

Description of changes

This updates kmscon to the latest release tag on the repository, after 3 years(!) without an update in Nixpkgs.

NOTE: This PR depends on #171069

Notifying maintainer; @omasanori

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[Infinidoge]

As noted in #178748, updating meson appears to have created a small variety of build errors due to the fortify hardening. It seems that meson is removing the -O2 flag from the hardening, causing the compiler to reject it due to the fortify hardening requiring the optimization flag.

This also occurred in the wayland-protocols package while building, which also uses meson.

[Infinidoge]

Was made aware that someone else made a meson PR, so retargetting this on top of that.

[Infinidoge]

Rebased on top of the meson changes and edited the PR message accordingly.

I didn't see anything in the Nixpkgs manual about the case of depending on another PR being merged, so my (current) assumption is that when the meson change is merged, the commits this PR has will be seen as already included and thus won't have duplicates, but I could very much be wrong.

Please let me know if I should just rebase out the commits this depends on.

Also since this update by itself shouldn't cause a mass rebuild, it still targets master.

[omasanori]

Thank you! I will check the changes in few days.

[omasanori]

Regarding Meson changes, I think it would be better to keep them out of this PR and wait for the separate PR to be merged.

[Infinidoge]

Rebased out the dependent commits.

[Infinidoge]

Incidentally included the auto-formatting my editor did for lines 1/2, 10/11, and 33/34, which I'm going to leave in since I personally prefer the expanded form. If I should revert that shift, please let me know.

[omasanori]

Incidentally included the auto-formatting my editor did for lines 1/2, 10/11, and 33/34, which I'm going to leave in since I personally prefer the expanded form. If I should revert that shift, please let me know.

It is acceptable to me.

By the way, what kind of tests have you done? Just completed a build or running the kmscon service with this? While I will do some tests this weekend anyways, I'd know what is succeeded on your machine.

[Infinidoge]

While I haven't done so yet, I'll be swapping out my version to the updated one later today. (I had actually been tracking with the kmscon master branch up until the meson change, since I didn't change the build system at the time. Now seemed like a good time.)

The main testing I've been doing is checking out the command line arguments, and making sure it builds.

[Infinidoge]

For those who want to more easily test the changes using flakes, I've made a branch on my nixpkgs fork that combines the meson and kmscon changes: https://github.com/Infinidoge/nixpkgs/tree/combined/kmscon
(github:Infinidoge/nixpkgs/combined/kmscon)

[Infinidoge]

Seems to be running just fine on my machine, which is good:

Since the relative feature changes were small, it's a bit hard to test them specifically, however I am setting up a compose key to try using that under kmscon.

[AndersonTorres]

Waiting for the next meson.

[omasanori]

While I have still been building the system on my old laptop, I reviewed changes between two commits briefly and finds no huge and risky changes.

Feel free to merge this when meson is updated even if I have not yet reported the result on my machine at that moment. I will test as soon as possible though.

[omasanori]

I had tested underline, italic and multilingual text with emacs-nox, noto-fonts and noto-fonts-cjk-sans and confirmed that it works. Thanks @Infinidoge !

[Mindavi]

In my opinion, downstream packagers should never compile with Werror, since it can break on compiler updates. That's ubdesirable since a compiler update (generally) won't make the source code less safe in any way. And the compiler shouldn't be assumed anyway since different distros may use different compilers.

[Mindavi]

So my suggestion is to add a blanket -Wno-error (or set a flag that does that)

[Infinidoge]

Since the dependent PR has been merged, is there anything that needs to be done before this can be merged?

[Mindavi]

@ofborg eval

[Infinidoge]

Also, it seems that the meson changes have made their way into master, should I go ahead and retarget to there, since this change itself doesn't cause a mass rebuild?

[Infinidoge]

Oh wait it already is targetting master, nevermind