You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This updates meson to the latest version, which was necessary for my upcoming PR to bump kmscon to the latest version. Several patches were removed due to being upstreamed.
HOWEVER: This definitely needs feedback, because running the nixpkgs review command below appears to fail, with the error message:
error: Function called without required argument "lzma" at /home/infinidoge/.cache/nixpkgs-review/rev-d55fcf6acf96287efc540014758f67fddbd4dc69/nixpkgs/pkgs/development/libraries/avro-c/default.nix:1, did you mean "lima", "czmq" or "emma"?
(Before that there was a very long list of packages)
I'm unsure what caused this, because the avro-c/default.nix mentions nothing about meson, but thought it worth noting here.
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
I think I may know the issue,
It might be possible that for some reason, this latest meson update conflicts with the fortify hardening, (kmscon and wayland-protocols, which both used meson, threw the same error about FORTIFY_SOURCE)
The issue there being that it seems like it is trying to compile with fortify without including the optimization level.
In both cases of kmscon and wayland-protocols, adding hardeningDisable = [ "fortify" ]; resolves the issue, but doing that tree-wide for meson-built software seems unwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8.has: package (update)This PR updates a package to a newer version10.rebuild-darwin: 501+This PR causes many rebuilds on Darwin and should normally target the staging branches.10.rebuild-darwin: 5001+This PR causes many rebuilds on Darwin and must target the staging branches.10.rebuild-linux: 501+This PR causes many rebuilds on Linux and should normally target the staging branches.10.rebuild-linux: 5001+This PR causes many rebuilds on Linux and must target the staging branches.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This updates meson to the latest version, which was necessary for my upcoming PR to bump kmscon to the latest version. Several patches were removed due to being upstreamed.
HOWEVER: This definitely needs feedback, because running the nixpkgs review command below appears to fail, with the error message:
(Before that there was a very long list of packages)
I'm unsure what caused this, because the
avro-c/default.nixmentions nothing aboutmeson, but thought it worth noting here.Due to the issue above, notifying maintainers: @jtojnar @AndersonTorres @brandonedens
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes