Skip to content

python3.pkgs.sphinxcontrib-log-cabinet: init at 1.0.1#172735

Closed
KAction wants to merge 2 commits intoNixOS:masterfrom
KAction:sphinxcontrib-log-cabinent
Closed

python3.pkgs.sphinxcontrib-log-cabinet: init at 1.0.1#172735
KAction wants to merge 2 commits intoNixOS:masterfrom
KAction:sphinxcontrib-log-cabinent

Conversation

@KAction
Copy link
Contributor

@KAction KAction commented May 12, 2022

  • python3.pkgs.sphinx-pallets-theme: init at 2.0.2
  • python3.pkgs.sphinxcontrib-log-cabinent: init at 1.0.1
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@KAction KAction requested review from FRidh and jonringer as code owners May 12, 2022 18:28
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 12, 2022
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 12, 2022
@pbsds
Copy link
Member

pbsds commented Aug 6, 2022

This pr seems to also include the changes in #172731.
I suggest you either rebase this pr to not include the other PR, or to close the other PR.

Result of nixpkgs-review pr 172735 run on x86_64-linux 1

4 packages built:
  • python310Packages.sphinx-pallets-theme
  • python310Packages.sphinxcontrib-log-cabinet
  • python39Packages.sphinx-pallets-theme
  • python39Packages.sphinxcontrib-log-cabinet

@flokli
Copy link
Member

flokli commented Aug 26, 2022

Same review comments from #172731 apply here, too:

  • please fetch from pypi rather than github
  • please rebase this to only PR in sphinxcontrib-log-cabinet, not the other PR. They are unrelated packages.

@pbsds
Copy link
Member

pbsds commented Aug 30, 2022 •
edited
Loading

Seems like the other PR got merged. I suggest we close this one

@KAction KAction force-pushed the sphinxcontrib-log-cabinent branch from 1e159bf to c7850df Compare August 30, 2022 21:42
@KAction
Copy link
Contributor Author

KAction commented Aug 30, 2022

No, we need log-cabinet. I dropped pallets-sphinx-themes commit.

@KAction KAction force-pushed the sphinxcontrib-log-cabinent branch from 6f9b86f to d282352 Compare September 13, 2022 00:23
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 15, 2022
@KAction KAction closed this May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KAction @pbsds @flokli @mweinelt