Skip to content

python3.pkgs.pallets-sphinx-theme: init at 2.0.2#172731

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
KAction:master
Aug 29, 2022
Merged

python3.pkgs.pallets-sphinx-theme: init at 2.0.2#172731
mweinelt merged 1 commit intoNixOS:masterfrom
KAction:master

Conversation

@KAction
Copy link
Contributor

@KAction KAction commented May 12, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@KAction KAction requested review from FRidh and jonringer as code owners May 12, 2022 18:07
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 12, 2022
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 12, 2022
@pbsds
Copy link
Member

pbsds commented Aug 6, 2022

Result of nixpkgs-review pr 172731 run on x86_64-linux 1

2 packages built:
  • python310Packages.sphinx-pallets-theme
  • python39Packages.sphinx-pallets-theme

Copy link
Member

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, otherwise LGTM.

pythonImportsCheck = [ "pallets_sphinx_themes" ];

meta = with lib; {
homepage = "https://github.com/pallets/pallets-sphinx-themes/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = "https://github.com/pallets/pallets-sphinx-themes/";
homepage = "https://github.com/pallets/pallets-sphinx-themes";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@KAction KAction force-pushed the master branch 2 times, most recently from 19be8d9 to 7e538cf Compare August 26, 2022 22:50
@KAction KAction closed this Aug 29, 2022
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 29, 2022
@KAction KAction reopened this Aug 29, 2022
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 29, 2022
@KAction KAction force-pushed the master branch 2 times, most recently from a4ce0f7 to 4fef406 Compare August 29, 2022 23:26
@KAction KAction changed the title python3.pkgs.sphinx-pallets-theme: init at 2.0.2 python3.pkgs.pallets-sphinx-theme: init at 2.0.2 Aug 29, 2022
@mweinelt mweinelt merged commit 24b8325 into NixOS:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants