Skip to content

chatty: use makeShellWrapper#172646

Closed
dotlambda wants to merge 1 commit intoNixOS:masterfrom
dotlambda:chatty-makeShellWrapper
Closed

chatty: use makeShellWrapper#172646
dotlambda wants to merge 1 commit intoNixOS:masterfrom
dotlambda:chatty-makeShellWrapper

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented May 12, 2022 •
edited
Loading

Description of changes

fallout of #172320

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

ZHF: #172160

⚠️ This conflicts with #172366.

@dotlambda dotlambda requested review from ncfavier and xaverdh May 12, 2022 01:47
@ofborg ofborg bot requested a review from tomfitzhenry May 12, 2022 02:03
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 12, 2022
@ncfavier
Copy link
Member

ncfavier commented May 12, 2022

Is this necessary? chatty is already fixed by #171836

@dotlambda
Copy link
Member Author

dotlambda commented May 12, 2022

Is this necessary? chatty is already fixed by #171836

It's not. I didn;t know about that PR yet and the maintainers weren't pinged.

@dotlambda dotlambda closed this May 12, 2022
@dotlambda dotlambda deleted the chatty-makeShellWrapper branch May 12, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncfavier ncfavier Awaiting requested review from ncfavier

@xaverdh xaverdh Awaiting requested review from xaverdh

@tomfitzhenry tomfitzhenry Awaiting requested review from tomfitzhenry

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dotlambda @ncfavier