Fix wrapper arguments escaping#171836
Merged
thiagokokada merged 18 commits intoNixOS:masterfrom May 12, 2022
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 11-100
Member
Author
|
@ofborg build image_optim megapixels chatty tremc jameica soapysdr qucs-s vdr podman i3blocks-gaps hunspell nuspell hci hercules-ci-agent sqitchMysql navidrome pufferpanel ibus-engines.typing-booster |
Member
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 31 packages built:
|
13 tasks
SuperSandro2000
approved these changes
May 12, 2022
Member
There was a problem hiding this comment.
Escaping shouldn't hurt but this is always set.
dotlambda
reviewed
May 12, 2022
ncfavier
force-pushed
the
escape-wrapper-args
branch
from
e87c0da to
163f818
Compare
Member
|
Result of 29 packages built:
|
thiagokokada
approved these changes
May 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some packages invoke
makeWrapperlike this:The lack of escaping is a problem in cases where
binsmight be an empty string. The problem is becoming more apparent with #164163 merged, becausemakeWrapperused to silently do nothing if the third argument to--prefixis missing, whilemakeBinaryWrapperfails.This PR fixes all instances of this pattern I could find where
binshas a chance of being empty (hence leaving alone statically okay cases like--prefix PATH : ${lib.makeBinPath [ hello ]}).ZHF #172160