Skip to content

python310Packages.twisted: adopt, run tests#171890

Merged
SuperSandro2000 merged 3 commits intoNixOS:stagingfrom
SuperSandro2000:twisted
May 18, 2022
Merged

python310Packages.twisted: adopt, run tests#171890
SuperSandro2000 merged 3 commits intoNixOS:stagingfrom
SuperSandro2000:twisted

Conversation

@SuperSandro2000
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 7, 2022
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels May 7, 2022
@risicle
Copy link
Contributor

risicle commented May 7, 2022

See also #168407

@risicle
Copy link
Contributor

risicle commented May 7, 2022

On macos 10.15:

[ERROR]
Traceback (most recent call last):
  File "/nix/store/sjviiy408rwiksarcjgivhqx8d94iky1-python3.9-twisted-22.4.0/lib/python3.9/site-packages/twisted/trial/runner.py", line 691, in loadByName
    return self.suiteFactory([self.findByName(name, recurse=recurse)])
  File "/nix/store/sjviiy408rwiksarcjgivhqx8d94iky1-python3.9-twisted-22.4.0/lib/python3.9/site-packages/twisted/trial/runner.py", line 451, in findByName
    obj = reflect.namedModule(searchName)
  File "/nix/store/sjviiy408rwiksarcjgivhqx8d94iky1-python3.9-twisted-22.4.0/lib/python3.9/site-packages/twisted/python/reflect.py", line 156, in namedModule
    topLevel = __import__(name)
  File "/nix/store/sjviiy408rwiksarcjgivhqx8d94iky1-python3.9-twisted-22.4.0/lib/python3.9/site-packages/twisted/internet/test/test_process.py", line 1091, in <module>
    PTYProcessTestsBuilder_EPollReactorTests.test_openFileDescriptors.skip = "invalid syntax"
builtins.NameError: name 'PTYProcessTestsBuilder_EPollReactorTests' is not defined

twisted.internet.test.test_process
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/nix/store/sjviiy408rwiksarcjgivhqx8d94iky1-python3.9-twisted-22.4.0/lib/python3.9/site-packages/twisted/trial/runner.py", line 691, in loadByName
    return self.suiteFactory([self.findByName(name, recurse=recurse)])
  File "/nix/store/sjviiy408rwiksarcjgivhqx8d94iky1-python3.9-twisted-22.4.0/lib/python3.9/site-packages/twisted/trial/runner.py", line 451, in findByName
    obj = reflect.namedModule(searchName)
  File "/nix/store/sjviiy408rwiksarcjgivhqx8d94iky1-python3.9-twisted-22.4.0/lib/python3.9/site-packages/twisted/python/reflect.py", line 156, in namedModule
    topLevel = __import__(name)
  File "/nix/store/sjviiy408rwiksarcjgivhqx8d94iky1-python3.9-twisted-22.4.0/lib/python3.9/site-packages/twisted/internet/test/test_unix.py", line 1018, in <module>
    UNIXTestsBuilder_EPollReactorTests.test_sendFileDescriptorTriggersPauseProducing.skip = "sendFileDescriptor producer was not paused"
builtins.NameError: name 'UNIXTestsBuilder_EPollReactorTests' is not defined

twisted.internet.test.test_unix
-------------------------------------------------------------------------------
Ran 11156 tests in 85.458s

FAILED (skips=1633, errors=2, successes=9521)

@SuperSandro2000 SuperSandro2000 changed the base branch from master to staging May 8, 2022 21:24
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels May 8, 2022
@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented May 8, 2022

Waiting for #171354, a merge from master to staging and then going to rebase this PR.


@ofborg eval

@ofborg ofborg bot requested review from Enzime, exarkun, jluttine, lopsided98 and lukegb May 9, 2022 00:04
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 9, 2022
@ofborg ofborg bot requested a review from exarkun May 9, 2022 01:56
@SuperSandro2000 SuperSandro2000 marked this pull request as draft May 9, 2022 13:24
@SuperSandro2000 SuperSandro2000 force-pushed the twisted branch 2 times, most recently from 4711665 to 54cdadd Compare May 9, 2022 13:27
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review May 9, 2022 13:32
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 9, 2022
@SuperSandro2000 SuperSandro2000 merged commit 8f9ddc0 into NixOS:staging May 18, 2022
@SuperSandro2000 SuperSandro2000 deleted the twisted branch May 18, 2022 23:58
@Sigmanificient Sigmanificient added the 0.kind: package adoption Requests or PRs for adopting packages that have no maintainers label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: package adoption Requests or PRs for adopting packages that have no maintainers 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants