python3Packages.trytond: 6.2.6 -> 6.4.0 by dotlambda · Pull Request #171354 · NixOS/nixpkgs

dotlambda · 2022-05-03T05:28:05Z

Description of changes

Things done

gador · 2022-05-03T07:09:42Z

Could you elaborate a bit on why you had to add a new check dependency to flask-security-too?

dotlambda · 2022-05-03T07:14:06Z

Could you elaborate a bit on why you had to add a new check dependency to flask-security-too?

It was removed from passlib's propagatedBuildInputs. I'm just following what upstream flask-security-too does: https://github.com/Flask-Middleware/flask-security/blob/a3af228a2067db770152289c6d98a564553ff107/requirements/tests.txt#L9

gador · 2022-05-03T07:30:12Z

Could you elaborate a bit on why you had to add a new check dependency to flask-security-too?

It was removed from passlib's propagatedBuildInputs. I'm just following what upstream flask-security-too does: https://github.com/Flask-Middleware/flask-security/blob/a3af228a2067db770152289c6d98a564553ff107/requirements/tests.txt#L9

Thanks, that seems sensible.
But why do you include this change in the PR to update trytond? AFAIK it doesn't even depend on Flask-Security-Too. Did the build fail otherwise?

dotlambda · 2022-05-03T15:45:20Z

@gador I guess I should have called the PR "random Python stuff". I just started with trytond and then saw that passlib doesn't specify extras-require even though trytond depends on passlib[bcrypt] and passlib[argon2] so I went ahead and changed that.

dotlambda · 2022-05-04T03:43:03Z

@ofborg eval

dotlambda · 2022-05-08T11:17:56Z

Result of nixpkgs-review pr 171354 run on x86_64-linux 1

16 packages failed to build:

dyndnsc
napalm
odoo
privacyidea
python310Packages.ldaptor
python310Packages.mailman
python310Packages.mailman-hyperkitty
python310Packages.napalm
python310Packages.napalm-hp-procurve
python310Packages.privacyidea-ldap-proxy
python39Packages.json-logging
python39Packages.ldaptor
python39Packages.napalm
python39Packages.napalm-hp-procurve
python39Packages.privacyidea-ldap-proxy
zeroc-ice-cpp11

95 packages built:

alerta-server
buildbot (python39Packages.buildbot)
buildbot-full (python39Packages.buildbot-full)
buildbot-ui (python39Packages.buildbot-ui)
buildbot-worker (python39Packages.buildbot-worker)
cura
datadog-agent
datadog-process-agent
devpi-client
devpi-server
etebase-server (python39Packages.etebase-server)
etesync-dav
gnome-keysign
gns3-gui
gns3-server
grab-site
home-assistant-component-tests.roomba
home-assistant-component-tests.sentry
magic-wormhole (python39Packages.magic-wormhole)
mailman
mitmproxy (python39Packages.mitmproxy)
moodle-dl
moz-phab
murmur
netbox
octoprint
openai (python39Packages.openai)
paperless-ngx
pgadmin4
python310Packages.amqtt
python310Packages.autobahn
python310Packages.buildbot
python310Packages.buildbot-full
python310Packages.buildbot-ui
python310Packages.buildbot-worker
python310Packages.channels
python310Packages.channels-redis
python310Packages.ciscoconfparse
python310Packages.daphne
python310Packages.dependency-injector
python310Packages.etebase-server
python310Packages.fastapi
python310Packages.flask-security-too
python310Packages.labgrid
python310Packages.magic-wormhole
python310Packages.magic-wormhole-mailbox-server
python310Packages.mitmproxy
python310Packages.ormar
python310Packages.passlib
python310Packages.pg8000
python310Packages.pypiserver
python310Packages.relatorio
python310Packages.roombapy
python310Packages.slowapi
python310Packages.testing-postgresql
python310Packages.trytond
python310Packages.volvooncall
python39Packages.amqtt
python39Packages.autobahn
python39Packages.channels
python39Packages.channels-redis
python39Packages.ciscoconfparse
python39Packages.daphne
python39Packages.dependency-injector
python39Packages.django-rq
python39Packages.fastapi
python39Packages.flask-security-too
python39Packages.labgrid
python39Packages.magic-wormhole-mailbox-server
python39Packages.mailman
python39Packages.mailman-hyperkitty
python39Packages.ormar
python39Packages.passlib
python39Packages.pg8000
python39Packages.pypiserver
python39Packages.relatorio
python39Packages.roombapy
python39Packages.sentry-sdk
python39Packages.slowapi
python39Packages.spacy
python39Packages.spacy-loggers
python39Packages.spacy-transformers
python39Packages.testing-postgresql
python39Packages.textacy
trytond (python39Packages.trytond)
python39Packages.volvooncall
python39Packages.wandb
radicale
radicale2
skytemple
soco-cli
tahoe-lafs
theharvester
tribler
zeroc-ice

https://hg.tryton.org/relatorio/file/0.10.1/CHANGELOG

https://hg.tryton.org/trytond/file/6.4.0/CHANGELOG

pkgs/development/python-modules/twisted/default.nix

pkgs/development/python-modules/trytond/default.nix

pkgs/development/python-modules/relatorio/default.nix

SuperSandro2000 · 2022-05-08T21:14:40Z

pkgs/development/python-modules/passlib/default.nix

-  propagatedBuildInputs = [ bcrypt argon2_cffi ];
-  propagatedNativeBuildInputs = [ argon2_cffi ];


This is now lost which I think was really important.

Those are extra-requires.

Yes but extra-requires currently is not easy to use with propagatedNativeBuildInputs. I am not sure how we want to make sure people actually add both.

Why is propagatedNativeBuildInputs needed?

For cross-compilation 1cb0112

It's not perfect, but not depending on argon2_cffi at all should also fix cross-compilation.

cc @legendofmiracles

pkgs/development/python-modules/twisted/default.nix

SuperSandro2000 · 2022-05-08T23:21:29Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 171354 run on x86_64-linux 1

14 packages failed to build and already failed to build on hydra master:

napalm: log was empty
odoo: log was empty
privacyidea: log was empty
python310Packages.ldaptor: log was empty
python310Packages.mailman: log was empty
python310Packages.mailman-hyperkitty: log was empty
python310Packages.napalm: log was empty
python310Packages.napalm-hp-procurve: log was empty
python310Packages.privacyidea-ldap-proxy: log was empty
python39Packages.ldaptor: log was empty
python39Packages.napalm: log was empty
python39Packages.napalm-hp-procurve: log was empty
python39Packages.privacyidea-ldap-proxy: log was empty
zeroc-ice-cpp11: log was empty

97 packages built:

alerta-server
buildbot (python39Packages.buildbot)
buildbot-full (python39Packages.buildbot-full)
buildbot-ui (python39Packages.buildbot-ui)
buildbot-worker (python39Packages.buildbot-worker)
cura
datadog-agent
datadog-process-agent
devpi-client
devpi-server
dyndnsc
etebase-server (python39Packages.etebase-server)
etesync-dav
gnome-keysign
gns3-gui
gns3-server
grab-site
home-assistant-component-tests.roomba
home-assistant-component-tests.sentry
magic-wormhole (python39Packages.magic-wormhole)
mailman
mitmproxy (python39Packages.mitmproxy)
moodle-dl
moz-phab
murmur
netbox
octoprint
openai (python39Packages.openai)
paperless-ngx
pgadmin4
python310Packages.amqtt
python310Packages.autobahn
python310Packages.buildbot
python310Packages.buildbot-full
python310Packages.buildbot-ui
python310Packages.buildbot-worker
python310Packages.channels
python310Packages.channels-redis
python310Packages.ciscoconfparse
python310Packages.daphne
python310Packages.dependency-injector
python310Packages.etebase-server
python310Packages.fastapi
python310Packages.flask-security-too
python310Packages.labgrid
python310Packages.magic-wormhole
python310Packages.magic-wormhole-mailbox-server
python310Packages.mitmproxy
python310Packages.ormar
python310Packages.passlib
python310Packages.pg8000
python310Packages.pypiserver
python310Packages.relatorio
python310Packages.roombapy
python310Packages.slowapi
python310Packages.testing-postgresql
python310Packages.trytond
python310Packages.volvooncall
python39Packages.amqtt
python39Packages.autobahn
python39Packages.channels
python39Packages.channels-redis
python39Packages.ciscoconfparse
python39Packages.daphne
python39Packages.dependency-injector
python39Packages.django-rq
python39Packages.fastapi
python39Packages.flask-security-too
python39Packages.json-logging
python39Packages.labgrid
python39Packages.magic-wormhole-mailbox-server
python39Packages.mailman
python39Packages.mailman-hyperkitty
python39Packages.ormar
python39Packages.passlib
python39Packages.pg8000
python39Packages.pypiserver
python39Packages.relatorio
python39Packages.roombapy
python39Packages.sentry-sdk
python39Packages.slowapi
python39Packages.spacy
python39Packages.spacy-loggers
python39Packages.spacy-transformers
python39Packages.testing-postgresql
python39Packages.textacy
trytond (python39Packages.trytond)
python39Packages.volvooncall
python39Packages.wandb
radicale (radicale3)
radicale2
skytemple
soco-cli
tahoe-lafs
theharvester
tribler
zeroc-ice

dotlambda requested review from johbo, jonringer and mweinelt May 3, 2022 05:28

dotlambda requested a review from FRidh as a code owner May 3, 2022 05:28

github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 3, 2022

This was referenced May 3, 2022

python310Packages.relatorio: 0.10.0 -> 0.10.1 #171341

Closed

python310Packages.trytond: 6.2.6 -> 6.2.7 #168864

Closed

ofborg bot requested review from Ma27, erictapen, gador, globin, makefu and wd15 May 3, 2022 05:42

ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 3, 2022

ofborg bot added the ofborg-internal-error Ofborg encountered an error label May 3, 2022

cole-h removed the ofborg-internal-error Ofborg encountered an error label May 4, 2022

dotlambda force-pushed the trytond-6.4.0 branch from 711f751 to 64e28a9 Compare May 8, 2022 03:20

dotlambda added 5 commits May 8, 2022 20:30

python3Packages.passlib: specify extras-require

99ed271

python3Packages.relatorio: 0.10.0 -> 0.10.1

921f4f9

https://hg.tryton.org/relatorio/file/0.10.1/CHANGELOG

python3Packages.trytond: 6.2.6 -> 6.4.0

9959798

https://hg.tryton.org/trytond/file/6.4.0/CHANGELOG

privacyidea: fix sqlalchemy hash

c07476f

python3Packages.twisted: use extras-require

a2675e7

dotlambda force-pushed the trytond-6.4.0 branch from 64e28a9 to a2675e7 Compare May 8, 2022 20:32

dotlambda requested a review from SuperSandro2000 May 8, 2022 20:33

SuperSandro2000 requested changes May 8, 2022

View reviewed changes

SuperSandro2000 reviewed May 8, 2022

View reviewed changes

pkgs/development/python-modules/twisted/default.nix Show resolved Hide resolved

SuperSandro2000 mentioned this pull request May 8, 2022

python310Packages.twisted: adopt, run tests #171890

Merged

13 tasks

SuperSandro2000 merged commit 884ba7d into NixOS:master May 8, 2022

dotlambda deleted the trytond-6.4.0 branch May 8, 2022 23:36

		propagatedBuildInputs = [ bcrypt argon2_cffi ];
		propagatedNativeBuildInputs = [ argon2_cffi ];

Uh oh!

Conversation

dotlambda commented May 3, 2022

Description of changes

Things done

Uh oh!

gador commented May 3, 2022

Uh oh!

dotlambda commented May 3, 2022

Uh oh!

gador commented May 3, 2022

Uh oh!

dotlambda commented May 3, 2022

Uh oh!

dotlambda commented May 4, 2022

Uh oh!

dotlambda commented May 8, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SuperSandro2000 May 8, 2022

Choose a reason for hiding this comment

Uh oh!

dotlambda May 8, 2022

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 May 8, 2022

Choose a reason for hiding this comment

Uh oh!

dotlambda May 8, 2022

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 May 8, 2022

Choose a reason for hiding this comment

Uh oh!

dotlambda May 8, 2022

Choose a reason for hiding this comment

Uh oh!

dotlambda May 8, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SuperSandro2000 commented May 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants