update.py: updater vim updater #166941
update.py: updater vim updater #166941
Conversation
teto
force-pushed
the
vim-plugins-toml
branch
4 times, most recently
from
cff9349
to
2c5c1d7
Compare
We want to support plugins on other hosts than github. A more structured format will allow more features too.
vimPlugins: update vimPlugins: update
e.g., from simple strings to csv
|
i am afraid it will bitrot and there doesnt seem to be much interest in reviewing.I dont like it but will merge. From a pure nixpkgs user it shouldn't change anything. |
| @@ -987,18 +1372,6 @@ final: prev: | |||
| meta.homepage = "https://github.com/iamcco/coc-tailwindcss/"; | |||
| }; | |||
|
|
|||
| coc-nvim = buildVimPluginFrom2Nix { | |||
There was a problem hiding this comment.
What? coc-nvim got renamed to release below? This seems to have broken everyone's usage of coc-nvim plugin
There was a problem hiding this comment.
oups sry I put the branch in the wrong colum: https://github.com/NixOS/nixpkgs/pull/166941/files#r842990175 . I am away from keyboard for the next few hours if anyone want to fix it that would be awesome !
|
This currently broke coc-nvim (and possibly other renamings?) on |
| release = buildVimPluginFrom2Nix { | ||
| pname = "release"; | ||
| version = "2022-04-02"; | ||
| src = fetchFromGitHub { | ||
| owner = "neoclide"; | ||
| repo = "coc.nvim"; | ||
| rev = "d6a665bb13044d4899e2a3529c3ca68104d9b2f5"; | ||
| sha256 = "0pgzygvn5x2szm0fz12rlbblf1pk92r8p5fn8c7frxnmb2nsgsvd"; | ||
| }; | ||
| meta.homepage = "https://github.com/neoclide/coc.nvim/"; | ||
| }; |
| https://github.com/iamcco/coc-spell-checker/,, | ||
| https://github.com/coc-extensions/coc-svelte/,, | ||
| https://github.com/iamcco/coc-tailwindcss/,, | ||
| https://github.com/neoclide/coc.nvim/,,release |
There was a problem hiding this comment.
here it should be ...,release,
|
Also, even trying to use the renamed plugin, it seems to have stopped working on stable/latest nvim: |
|
just changing the line #166941 (review) and regenerating the file should fix it |
|
cool thanks for taking care of it. Sorry for the annoyance. I usually run a nixpkgs-review but I had no space anymorre :/ |
Ensure the kakoune updater works with the changes from NixOS#166941
We want to support plugins on other hosts than github. To ease that I've changed the format of vim-plugin-names to CSV, see #136248 for reasoning
A more structured format will allow more features too.
Fixes #136248 #166007
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes