Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem when vim plugin repo uri contains @ #166007

Closed
teto opened this issue Mar 27, 2022 · 1 comment
Closed

problem when vim plugin repo uri contains @ #166007

teto opened this issue Mar 27, 2022 · 1 comment

Comments

@teto
Copy link
Member

teto commented Mar 27, 2022

Describe the bug

It's not possible to add an url with a @ in vim-plugin-names.
For instance I tried
pkgs/applications/editors/vim/plugins/update.py --proc=10 --debug DEBUG --github-token=$GITHUB_TOKEN --add [email protected]:yorickpeterse/nvim-pqf.git
which triggered

Instantiating github repo ggandor/lightspeed.nvim
Instantiating github repo gibiansky/vim-textobj-haskell
Instantiating github repo gioele/vim-autoswap
Traceback (most recent call last):
  File "/home/teto/nixpkgs3/pkgs/applications/editors/vim/plugins/update.py", line 97, in <module>
    main()
  File "/home/teto/nixpkgs3/pkgs/applications/editors/vim/plugins/update.py", line 93, in main
    pluginupdate.update_plugins(editor, args)
  File "/home/teto/nixpkgs3/maintainers/scripts/pluginupdate.py", line 643, in update_plugins
    redirects = update()
  File "/home/teto/nixpkgs3/maintainers/scripts/pluginupdate.py", line 319, in update
    plugin_names = self.load_plugin_spec(config, input_file)
  File "/home/teto/nixpkgs3/maintainers/scripts/pluginupdate.py", line 306, in load_plugin_spec
    plugin = parse_plugin_line(config, line)
  File "/home/teto/nixpkgs3/maintainers/scripts/pluginupdate.py", line 518, in parse_plugin_line
    repo = make_repo(uri.strip(), branch.strip(), alias)
  File "/home/teto/nixpkgs3/maintainers/scripts/pluginupdate.py", line 503, in make_repo
    repo = RepoGitHub(res[0], res[1], branch, alias)
IndexError: list index out of range

vim-plugin-names expects owner/repo@branch and it splits on @. I passed [email protected]:yorickpeterse/nvim-pqf.git and so splitting on @ doesn't work here.

Additional context

The format of the file itself seems limiting see #136248

In the end I use nix-build -A vimPlugins.nvim-bqf since it seems more active but this issue could concern other plugins.

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
893ffca

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here 
@teto
Copy link
Member Author

teto commented Mar 29, 2022

nvim-pqf and bqf are not similar after all, I would rather use pqf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant