buildFHSUserEnv: fix error when share/glib-2.0/schemas is a link#164420
buildFHSUserEnv: fix error when share/glib-2.0/schemas is a link#164420Artturin merged 1 commit intoNixOS:masterfrom
Conversation
|
needs to be applied to to bublewrap fhs too
i'll run a nixpkgs-review once this fix has been applied to both fhsuserenvs |
|
@Artturin Thanks. I've updated it with your comments. |
|
|
Result of 2 packages marked as broken and skipped:
1 package blacklisted:
20 packages failed to build:
94 packages built:
|
An error would occur if share/glib-2.0/schema was a symlink.
|
@Artturin thanks for running that. I pushed it again with what should be a fix for steam, etc. One thing that bothers me about this implementation is all of these: When nothing matches the wildcard they'll create a symlink in cwd. It seems like there should be a better way to create 0..many symlinks, but the best I could come up with was a for loop over the wildcard, which is more verbose and still depends on nullglob. In any case it doesn't seem to break anything. |
|
Result of 2 packages marked as broken and skipped:
1 package blacklisted:
5 packages failed to build:
110 packages built:
|
|
No new failures Tested ssb-framework with Thanks! |
Description of changes
Fixes an error with
This seems to have been introduced by #161739, @Artturin.
WIP because:
.old?*okay without dotglob?Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes