Skip to content

buildFHSUserEnv{Chroot,Bubblewrap}: link gsettings-schemas to the FHS…#161739

Merged
Artturin merged 2 commits intoNixOS:masterfrom
Artturin:gsettingsfhsenv
Mar 14, 2022
Merged

buildFHSUserEnv{Chroot,Bubblewrap}: link gsettings-schemas to the FHS…#161739
Artturin merged 2 commits intoNixOS:masterfrom
Artturin:gsettingsfhsenv

Conversation

@Artturin
Copy link
Member

… location

Motivation for this change

Supersedes #83705

Things done

Tested by launching with XDG_DATA_DIRS= ./result/bin/ssb-patchwork and selecting a profile picture which opens a file picker

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Feb 24, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Feb 24, 2022
@Artturin Artturin force-pushed the gsettingsfhsenv branch 2 times, most recently from 6b4120c to df3f07d Compare February 26, 2022 00:20
@Artturin Artturin mentioned this pull request Mar 2, 2022
13 tasks
… location

We shouldn't need to use wrapGAppsHook in expressions
that use this builder.
@Artturin
Copy link
Member Author

Artturin commented Mar 2, 2022

moved mkdir -p $out/share/glib-2.0/schemas out of a if block to make sure it always exists

@Artturin Artturin requested a review from wentasah March 13, 2022 14:37
@Artturin
Copy link
Member Author

TODO remove gsettings-desktop-schemas and hicolor-icon-theme from packages that use the appimage builder

Result of nixpkgs-review pr 161739 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • ovftool
  • timedoctor
1 package blacklisted:
  • appimage-run-tests
5 packages failed to build:
  • ciscoPacketTracer7
  • ciscoPacketTracer8
  • houdini
  • quartus-prime-lite
  • runescape
109 packages built:
  • Sylk
  • altair
  • android-studio (androidStudioPackages.stable)
  • androidStudioPackages.beta
  • androidStudioPackages.canary
  • androidStudioPackages.dev
  • anki-bin
  • anytype
  • appimage-run
  • apple-music-electron
  • arduino
  • arduino-ci
  • arduino-cli
  • arduino-core
  • beekeeper-studio
  • betterdiscord-installer
  • beyond-identity
  • bitscope.chart
  • bitscope.console
  • bitscope.display
  • bitscope.dso
  • bitscope.logic
  • bitscope.meter
  • bitscope.proto
  • bitscope.server
  • bloomrpc
  • bottles
  • buttercup-desktop
  • chrysalis
  • clonehero
  • conda
  • cozy-drive
  • crypto-org-wallet
  • devdocs-desktop
  • dropbox
  • dropbox-cli
  • electron-mail
  • electronplayer
  • esphome
  • fahclient
  • firefly-desktop
  • flexoptix-app
  • flutter (flutterPackages.stable)
  • fspy
  • heroic
  • hover
  • irccloud
  • itch
  • itch-setup
  • joplin-desktop
  • keeweb
  • kodiPackages.steam-launcher
  • lbry
  • ledger-live-desktop
  • left4gore-bin
  • lens
  • lightworks
  • losslesscut-bin
  • lunar-client
  • lutris
  • lutris-free
  • marktext
  • mate.caja-dropbox
  • mathpix-snipping-tool
  • minigalaxy
  • mobilecoin-wallet
  • molotov
  • mycrypto
  • neo4j-desktop
  • notable
  • notion-app-enhanced
  • nuclear
  • octant-desktop
  • p3x-onenote
  • pdfstudio
  • pdfstudioviewer
  • platformio
  • playonlinux
  • plex
  • plexamp
  • protontricks
  • radicle-upstream
  • rambox-pro
  • saleae-logic-2
  • session-desktop-appimage
  • shticker-book-unwritten
  • sidequest
  • ssb-patchwork
  • standardnotes
  • station
  • steam
  • steam-run
  • steam-tui
  • steamcmd
  • teensyduino
  • timeular
  • trezor-suite
  • tusk
  • unityhub
  • unvanquished
  • via
  • vial
  • vmware-horizon-client
  • vscode-fhs
  • vscodium-fhs
  • wootility
  • ytmdesktop
  • zettlr
  • zulip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants