Skip to content

nixosTests.keepassxc: Add regression test for #163482#163608

Merged
turion merged 2 commits intoNixOS:masterfrom
turion:dev_fix_keepassxc_163482
Mar 21, 2022
Merged

nixosTests.keepassxc: Add regression test for #163482#163608
turion merged 2 commits intoNixOS:masterfrom
turion:dev_fix_keepassxc_163482

Conversation

@turion
Copy link
Contributor

@turion turion commented Mar 10, 2022 •
edited
Loading

Description of changes

Tries to add a regression test for #163482

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Mar 10, 2022
@turion
Copy link
Contributor Author

turion commented Mar 10, 2022

@underscore-j I tried to capture your instructions to reproduce the bug, but the test succeeds. See the changed test. You can run it with:

$ nix-build . -A nixosTests.keepassxc.driverInteractive
$ ./result/bin/nixos-test-driver --interactive

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 10, 2022
@underscore-j
Copy link

underscore-j commented Mar 10, 2022

If you add qt5.enable = true; so the settings are actually effective, it does indeed crash.

@underscore-j
Copy link

underscore-j commented Mar 10, 2022

(btw, it suffices to click on 'open existing database' to provoke a crash, in case you want the test to not take as long)

@turion turion force-pushed the dev_fix_keepassxc_163482 branch from 2280fd7 to 02fe318 Compare March 14, 2022 15:13
@turion
Copy link
Contributor Author

turion commented Mar 14, 2022

@underscore-j Thanks, with your help I was able to make a regression test, reproduce the bug and fix it.

@turion turion mentioned this pull request Mar 14, 2022
Closed
@turion
Copy link
Contributor Author

turion commented Mar 14, 2022

@ofborg test keepassxc

@turion
Copy link
Contributor Author

turion commented Mar 14, 2022

CC @jonafato

@ofborg ofborg bot requested a review from jonafato March 14, 2022 15:27
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 14, 2022
@turion turion force-pushed the dev_fix_keepassxc_163482 branch from 02fe318 to 53f2237 Compare March 18, 2022 15:48
@turion
Copy link
Contributor Author

turion commented Mar 18, 2022

Regression test works on my machine now, and the issue is fixed. @underscore-j can you test?

@turion
Copy link
Contributor Author

turion commented Mar 21, 2022

@ofborg test keepassxc

@underscore-j
Copy link

underscore-j commented Mar 21, 2022

Regression test works on my machine now, and the issue is fixed. @underscore-j can you test?

Yes, everything now works as expected. Thanks!

@turion turion merged commit 9046ecf into NixOS:master Mar 21, 2022
@turion turion deleted the dev_fix_keepassxc_163482 branch March 21, 2022 11:24
This was referenced Apr 22, 2022
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonafato jonafato Awaiting requested review from jonafato

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@turion @underscore-j