keepassxc: add 'wrapGAppsHook' to fix FileChooser error (see also: https://github.com/NixOS/nixpkgs/issues/111368)

[balazs-lengyel]

Motivation for this change

KeePassXC failed creating a DB with GLib-GIO-ERROR **: 11:16:48.748: Settings schema 'org.gtk.Settings.FileChooser' is not installed.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[sugar700]

Huh, that's interesting, KeepassXC is not a GTK application, however apparently it's possible to configure Qt applications to use GTK with QT_QPA_PLATFORMTHEME=gtk3. That has interesting implications for all Qt applications in Nixpkgs.

[sugar700]

Seems like #136071 could be related, cc @jtojnar.

[SuperSandro2000]

This double wraps the binary if I am not mistaken. Please add the wrapper arguments to wrapperArgs.

[balazs-lengyel]

is this a valid fix to your concerns? (taken from https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/gnome.section.md)

[SuperSandro2000]

nixpkgs/pkgs/applications/graphics/tev/default.nix

Line 34 in 76e0a00

wrapProgram $out/bin/tev \

[turion]

What issue did this fix? I've never heard of this problem.

[balazs-lengyel]

@turion keepassxc crashes on selecting the location for the new DB file under a fresh nixos+gnome install.

[turion]

That explains why it doesn't have any problems in KDE.

[SuperSandro2000]

nixpkgs/pkgs/applications/graphics/tev/default.nix

Line 34 in 76e0a00

wrapProgram $out/bin/tev \

[SuperSandro2000]

I am not sure if this is enough.

[turion]

Why is double wrapping a problem? To me it looks like a more maintainable and clear solution.

[balazs-lengyel]

I agree with @turion that double-wrapping should be the way to go, since it is the most maintainable solution. Should I change this back?

[jtojnar]

Double wrapping is a problem because Linux does not support passing setting argv[0] when execing a script. That means argv[0] will contain .program-wrapped, which will likely get used in --help at best, and prevent the program from finding its resources at worst.

[stale]

I marked this as stale due to inactivity. → More info

[turion]

Double wrapping is a problem because Linux does not support passing setting argv[0] when execing a script. That means argv[0] will contain .program-wrapped, which will likely get used in --help at best, and prevent the program from finding its resources at worst.

Ah, ok. Quite a few (~ 10) programs in nixpkgs do this, though. Since this seems like a popular thing to do, and they all do it wrong, allegedly, maybe there should be a standard "double wrapper" wrapQtAndGAppsHook containing both wrapping args.

[Artturin]

can't repro the error on master XDG_DATA_DIRS= QT_QPA_PLATFORMTHEME=gtk3 ./result/bin/keepassx

[turion]

This is my fault. I added double wrapping in #163608, not realizing that there are downsides.

For keepassxc at least, everything works sort of as expected:

$ keepassxc --help
Usage: /nix/store/bsn1wir6x2jiin6jdp3jzl4ja98b2yxn-keepassxc-2.6.6/bin/.keepassxc-wrapped [options] [filename(s)]
KeePassXC - cross-platform password manager

Options:
  -h, --help                   Displays help on commandline options.
  --help-all                   Displays help including Qt specific options.
  -v, --version                Displays version information.
  --config <config>            path to a custom config file
  --localconfig <localconfig>  path to a custom local config file
  --lock                       lock all open databases
  --keyfile <keyfile>          key file of the database
  --pw-stdin                   read password of the database from stdin
  --debug-info                 Displays debugging information.

Arguments:
  filename(s)                  filenames of the password databases to open
                               (*.kdbx)