Flutter fixup

[mkg20001]

Motivation for this change

Packaging some more things for flutter to check and smooth out the raw edges of mkFlutterApp

If yov've got any comments regarding #147107 this is the place to comment

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[SuperSandro2000]

What is this? Why not just use buildPhase with preHooks? Looks to me a lot easier overhaul.

[mkg20001]

How do you mean with prehooks? The idea is the user is able to overwrite buildPhase but can optionally call the original one somewhere in the middle of it. What would be the best way to accomplish this?

[SuperSandro2000]

If you want to run something before you would put it into preBuild and for after into postBuild. Basically this would already achieve this:

Suggested change

	preConfigurePhases = [ "flutterConfigurePhase" ];
	# avoid cmake phase
	configurePhase = "true";
	flutterBuildPhase = ''
	# for some reason fluffychat build breaks without this - seems file gets overriden by some tool
	mv pubspec-backup pubspec.yaml
	mkdir -p build/flutter_assets/fonts
	flutter packages get --offline -v
	flutter build linux --release -v
	'';
	buildPhase = ''
	runHook preBuild
	runHook flutterBuildPhase
	runHook postBuild
	'';
	preConfigurePhases = [ "flutterConfigurePhase" ];
	# avoid cmake phase
	configurePhase = "true";
	buildPhase = ''
	runHook preBuild
	# for some reason fluffychat build breaks without this - seems file gets overriden by some tool
	mv pubspec-backup pubspec.yaml
	mkdir -p build/flutter_assets/fonts
	flutter packages get --offline -v
	flutter build linux --release -v
	runHook postBuild
	'';

[mkg20001]

Hrm I'll leave the phases as-is for now. It was initially added to package appflowy, but that is already packaged as bin derivation.

[SuperSandro2000]

Suggested change

	configurePhase = "true";
	dontConfigure = true;

[mkg20001]

The user might want to overwrite configurePhase and then it would be skipped. Also using preConfigurePhases not sure if this will work.

[SuperSandro2000]

What happens if we just leave configurePhase and don't do anything to it? Maybe we just want to disable cmake and ninja?