Skip to content

Add flutter support to nixpkgs#147107

Merged
mkg20001 merged 4 commits intoNixOS:masterfrom
mkg20001:flutter
Feb 19, 2022
Merged

Add flutter support to nixpkgs#147107
mkg20001 merged 4 commits intoNixOS:masterfrom
mkg20001:flutter

Conversation

@mkg20001
Copy link
Copy Markdown
Member

@mkg20001 mkg20001 commented Nov 23, 2021

Motivation for this change

Implementation is dumpsterfire for now, but despite that it does work

I'll refine things until they are good enough. Reviews esp implementation tips appreciated

Testing can be done using "nix-build -A fluffychat"

Todos:

  • cleanup mkFlutterApp
  • remove hacks if possible
  • possibly package more apps to check which deps we actually need
  • make FOD stable
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 23, 2021
@Synthetica9 Synthetica9 marked this pull request as draft November 23, 2021 11:56
@mkg20001
Copy link
Copy Markdown
Member Author

Look and behold, it works ^^

fucking works

Now's time to clean this frankensteins monster

@mkg20001 mkg20001 force-pushed the flutter branch 3 times, most recently from de5de35 to 477e854 Compare November 24, 2021 00:58
@mkg20001 mkg20001 requested a review from Synthetica9 December 4, 2021 12:19
@github-actions github-actions bot added the 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) label Dec 4, 2021
@mkg20001 mkg20001 force-pushed the flutter branch 2 times, most recently from 4a36961 to 2e6cda8 Compare December 4, 2021 13:44
@mkg20001 mkg20001 marked this pull request as ready for review December 4, 2021 13:45
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 4, 2021
@mkg20001 mkg20001 force-pushed the flutter branch 3 times, most recently from 21e36df to 860083a Compare December 4, 2021 14:14
@mkg20001 mkg20001 self-assigned this Dec 4, 2021
@mkg20001
Copy link
Copy Markdown
Member Author

mkg20001 commented Dec 4, 2021

I've started packaging some other apps in a branch https://github.com/NixOS/nixpkgs/compare/master...mkg20001:flutter-apps?expand=1 to see what needs to be adjusted for making this more general purpose

This should mostly be ready for merge now

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 4, 2021
@TilCreator
Copy link
Copy Markdown
Contributor

I compiled Fluffychat Version 1.1.0.
it does work nicely. But encryption support is missing in 1.1.0 and 0.41.2, even though olm is in buildInputs, so not sure what the reason is there.

@colemickens
Copy link
Copy Markdown
Member

There's AppFlowy which I have my eye on, but it's Flutter... and Rust: https://github.com/AppFlowy-IO/appflowy

@colemickens
Copy link
Copy Markdown
Member

That slipped out a bit randomly, optimistically. My first thoughts were, wow, thank you for doing this. I can't wait.

@Misterio77
Copy link
Copy Markdown
Member

Hey, i'm interested in building flutter web apps at my job using Nix. Could this work for web target too? If not, could you point at how you packaged the SDK stuff flutter downloads at runtime?

@mkg20001 mkg20001 force-pushed the flutter branch 3 times, most recently from f67bd7f to 4607f57 Compare February 19, 2022 14:04
mkg20001 and others added 2 commits February 19, 2022 15:07
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@ofborg ofborg bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Feb 19, 2022
@mkg20001
Copy link
Copy Markdown
Member Author

This is already big enough as it is and so that I don't slack another month on some improvements I'll just go ahead and merge this. The apps work, but haven't tested in-depth.

@mkg20001 mkg20001 merged commit 1af6696 into NixOS:master Feb 19, 2022
@mkg20001 mkg20001 deleted the flutter branch February 19, 2022 15:04
@mkg20001 mkg20001 mentioned this pull request Feb 19, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants