Skip to content

python3Packages.stack-data: 0.1.0 -> 0.2.0#160031

Merged
jonringer merged 2 commits intoNixOS:stagingfrom
collares:sage-stackdata
Feb 21, 2022
Merged

python3Packages.stack-data: 0.1.0 -> 0.2.0#160031
jonringer merged 2 commits intoNixOS:stagingfrom
collares:sage-stackdata

Conversation

@collares
Copy link
Member

@collares collares commented Feb 14, 2022

Motivation for this change

python3Packages.stack-data, a dependency of IPython 8, contains fixes which would be useful to Sage.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 14, 2022
@collares collares mentioned this pull request Feb 14, 2022
Merged
13 tasks
@collares
Copy link
Member Author

collares commented Feb 14, 2022

@jonringer I don't know if this should target python-unstable instead. Feel free to change it or to let me know.

@jonringer
Copy link
Contributor

jonringer commented Feb 14, 2022

The last python updates just landed in master, I don't think there's any plan to do anything like that

@ofborg ofborg bot requested a review from jluttine February 14, 2022 19:58
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Feb 14, 2022
@collares
Copy link
Member Author

collares commented Feb 20, 2022

@jluttine Ping :) This is a big quality-of-life improvement for Sage users due to alexmojaki/stack_data#21 (most of the Sage library is implemented in Cython).

@collares
Copy link
Member Author

collares commented Feb 20, 2022

@ofborg build python3Packages.ipython

@collares collares requested a review from bjornfor February 20, 2022 21:34
jonringer
jonringer approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 160031 run on x86_64-linux 1

1 package built:
  • python3Packages.ipython

@collares collares deleted the sage-stackdata branch February 22, 2022 00:08
@collares
Copy link
Member Author

collares commented Feb 22, 2022

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jluttine jluttine Awaiting requested review from jluttine

@bjornfor bjornfor Awaiting requested review from bjornfor

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@collares @jonringer