sage: don't test for Cython source code in tracebacks (temporarily)#159351
Merged
7c6f434c merged 1 commit intoNixOS:masterfrom Feb 14, 2022
Merged
sage: don't test for Cython source code in tracebacks (temporarily)#1593517c6f434c merged 1 commit intoNixOS:masterfrom
7c6f434c merged 1 commit intoNixOS:masterfrom
Conversation
Member
Author
|
Thanks for merging! This will be a temporary fix indeed, since upstream IPython just fixed this properly. But the fix will have to go through staging, so it's great to have this one merged already. |
Member
Author
|
#160031 (targeting staging) removes this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
To emit better tracebacks, IPython 8 (#154969) parses Python files using the
astmodule (via thestack_datapackage). Since Cython is a superset of Python, this results in no Cython code being printed in tracebacks. Fixing this properly is tracked in alexmojaki/stack_data#21, but for now we just disable the corresponding test. An alternative would be to revert IPython's IPython/core/ultratb.py, but this would need to be Sage-specific (since it would worsen tracebacks for pure Python code).Sage tracks the IPython 8 upgrade at https://trac.sagemath.org/ticket/33170, a ticket which also includes two minor test changes. I added those to this PR as well.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes