Skip to content

nixos/step-ca: Remove unnecessary passthru.tests#159692

Merged
roberth merged 1 commit intoNixOS:masterfrom
mohe2015:patch-1
Feb 14, 2022
Merged

nixos/step-ca: Remove unnecessary passthru.tests#159692
roberth merged 1 commit intoNixOS:masterfrom
mohe2015:patch-1

Conversation

@mohe2015
Copy link
Contributor

@mohe2015 mohe2015 commented Feb 12, 2022

Motivation for this change

cc @ju1m

See #145695 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 12, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 13, 2022
ju1m
ju1m suggested changes Feb 13, 2022
View reviewed changes
Copy link
Contributor

@ju1m ju1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixosTests should also be removed from the top attrset.
Except for that, LGTM. Thanks!

@roberth
Copy link
Member

roberth commented Feb 14, 2022

We could have a meta.tests option for this purpose, but I can't think of a non-human consumer for that info.

@roberth roberth merged commit 81302f1 into NixOS:master Feb 14, 2022
@mohe2015 mohe2015 deleted the patch-1 branch February 14, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roberth roberth roberth approved these changes

+1 more reviewer

@ju1m ju1m ju1m approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohe2015 @roberth @ju1m