Skip to content

nixos/tests: add step-ca test#145695

Merged
ajs124 merged 1 commit intoNixOS:masterfrom
mohe2015:step-ca-tests
Dec 2, 2021
Merged

nixos/tests: add step-ca test#145695
ajs124 merged 1 commit intoNixOS:masterfrom
mohe2015:step-ca-tests

Conversation

@mohe2015
Copy link
Contributor

Motivation for this change

This is more or less what I check on updates.

Things done

Probably IFD is not allowed but we will see. If its not allowed the only way is to put the files in-repo I suppose.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 12, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 12, 2021
@mohe2015
Copy link
Contributor Author

@ofborg build step-ca.passthru.tests

@mohe2015
Copy link
Contributor Author

@ofborg build step-ca.passthru.tests

@mohe2015
Copy link
Contributor Author

Would it be possible to get this merged before branchoff so it's in the next release?

@dasJ dasJ requested a review from ajs124 November 15, 2021 20:08
@mohe2015
Copy link
Contributor Author

mohe2015 commented Dec 1, 2021

Any chance to get this merged? Should be fairly uncontroversial.

@ajs124 ajs124 requested a review from m1cr0man December 2, 2021 00:49
Copy link
Contributor

@m1cr0man m1cr0man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks good to me. I'm not all too familiar with step-ca but this seems fine. Nice to have the tests in case I break something in acme that affects it ;)

@ajs124 ajs124 merged commit 559552e into NixOS:master Dec 2, 2021
@mohe2015 mohe2015 deleted the step-ca-tests branch December 3, 2021 06:02
@ju1m
Copy link
Contributor

ju1m commented Feb 12, 2022

Looks like this is the only use of passthru.tests in nixos/modules/, is it a deliberate choice or a mistake? Isn't the passthru.tests in pkgs/tools/security/step-ca/default.nix enough? Thanks in advance for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants