Merged
Conversation
Contributor
Author
|
@ofborg build step-ca.passthru.tests |
48c9f90 to
9d01ce8
Compare
Contributor
Author
|
@ofborg build step-ca.passthru.tests |
Contributor
Author
|
Would it be possible to get this merged before branchoff so it's in the next release? |
Contributor
Author
|
Any chance to get this merged? Should be fairly uncontroversial. |
m1cr0man
approved these changes
Dec 2, 2021
Contributor
m1cr0man
left a comment
There was a problem hiding this comment.
The test looks good to me. I'm not all too familiar with step-ca but this seems fine. Nice to have the tests in case I break something in acme that affects it ;)
Contributor
|
Looks like this is the only use of |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is more or less what I check on updates.
Things done
Probably IFD is not allowed but we will see. If its not allowed the only way is to put the files in-repo I suppose.
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)