portaudio: build with JACK on linux#157561
Closed
starcraft66 wants to merge 2 commits intoNixOS:stagingfrom
Closed
portaudio: build with JACK on linux#157561starcraft66 wants to merge 2 commits intoNixOS:stagingfrom
starcraft66 wants to merge 2 commits intoNixOS:stagingfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
LGTM. fixes for me the problem of missing jack output |
poelzi
approved these changes
Feb 2, 2022
Member
|
@Mic92 can you merge please :) |
Artturin
added
the
12.approvals: 1
|
Hello, seems this might not get merged, so could you teach me how to add this to my NixOS system? |
Member
Author
|
@visceralchokehold Example from my config, you can add that snippet to your packages: https://github.com/starcraft66/os-config/blob/master/flake.nix#L54-L57 |
Member
Author
|
Looks like this rotted enough to accumulate a merge conflict, just committed a resolution via the web interface. It should still build... |
ofborg
bot
added
10.rebuild-linux: 1001-2500
bobby285271
removed
the
12.approvals: 1
13 tasks
13 tasks
Member
|
Superseded by #215284 We can build portaudio with jack on darwin too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Applications relying on PortAudio such as Mixxx cannot use the JACK audio backend.
I tested this on my system and Mixxx now correctly detects JACK. This caused a fairly long rebuild on my computer due to webkitgtk, libreoffice and Chromium among others depending on PortAudio. I expect this change to trigger a mass rebuild so I will target it against staging.
Fixes #157529
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes