Conversation
github-actions
bot
added
the
6.topic: GNOME
25 tasks
ofborg
bot
added
11.by: package-maintainer
ofborg
bot
added
10.rebuild-linux: 11-100
dasj19
reviewed
Jan 2, 2022
Contributor
dasj19
left a comment
dasj19
left a comment
There was a problem hiding this comment.
Looks good, except I don't understand why the nautilus patch has some files excluded.
And most of the patches were accepted upstream. That's always a good sign.
| sha256 = "xSb9l7xxEYpAwmdmeWT/t7Z9Ck3DPtsODzbReQW/Q70="; | ||
| excludes = [ | ||
| "build-aux/flatpak/org.gnome.Nautilus.json" | ||
| "build-aux/flatpak/org.gnome.Nautilus.yml" |
Contributor
There was a problem hiding this comment.
why exculding these two files?
Member
Author
There was a problem hiding this comment.
Due to merge conflicts and irrelevancy (the Flatpak manifest is only used for building Flatpak package).
Contributor
There was a problem hiding this comment.
Ok I can see now that building flatpaks is irrelevant for us. Thanks for explaining.
dasj19
approved these changes
Jan 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.