Skip to content

Comments

pango,gtk3,gtk4,libadwaita: update#152948

Merged
jtojnar merged 9 commits intoNixOS:stagingfrom
jtojnar:adw1
Jan 2, 2022
Merged

pango,gtk3,gtk4,libadwaita: update#152948
jtojnar merged 9 commits intoNixOS:stagingfrom
jtojnar:adw1

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Dec 31, 2021 •
edited by bobby285271
Loading

Motivation for this change
  • authenticator – already broken
  • metadata-cleaner – works
  • notejot ­– notejot: 3.2.0 -> 3.3.3 (tagged 3.4.9) #153022
  • kooha – fixed dep lookup, works
  • clapper – no warnings but crashes when playing
  • khronos – works
  • mousai – works
  • spot – works
  • shortwave – marked as broken
  • gnome-todo – updated to master
  • xdg-desktop-portal-gnome – works
  • ashpd-demo – marked as broken
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Dec 31, 2021
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 31, 2021
@jtojnar jtojnar changed the base branch from master to staging December 31, 2021 16:31
@jtojnar jtojnar mentioned this pull request Dec 31, 2021
Merged
@bobby285271 bobby285271 mentioned this pull request Jan 1, 2022
Merged
3 tasks
dasj19
dasj19 approved these changes Jan 1, 2022
View reviewed changes
Copy link
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good to me

@jtojnar
Copy link
Member Author

jtojnar commented Jan 1, 2022

gnome-todo is also broken like notejot:

(gnome-todo:171718): Gtk-CRITICAL **: 21:59:03.455: Error building template class 'GtdWindow' for an instance of type 'GtdWindow': .:0:0 Invalid property: AdwLeaflet.can-swipe-back

(gnome-todo:171718): Gtk-CRITICAL **: 21:59:03.455: gtk_list_box_bind_model: assertion 'GTK_IS_LIST_BOX (box)' failed

(gnome-todo:171718): Gtk-CRITICAL **: 21:59:03.455: gtk_menu_button_set_menu_model: assertion 'GTK_IS_MENU_BUTTON (menu_button)' failed

(gnome-todo:171718): Gtk-CRITICAL **: 21:59:03.455: gtk_menu_button_get_popover: assertion 'GTK_IS_MENU_BUTTON (menu_button)' failed

(gnome-todo:171718): Adwaita-WARNING **: 21:59:03.456: Using GtkSettings:gtk-application-prefer-dark-theme with libadwaita is unsupported. Please use AdwStyleManager:color-scheme instead.

(gnome-todo:171718): Adwaita-WARNING **: 21:59:03.457: Using GtkSettings:gtk-application-prefer-dark-theme with libadwaita is unsupported. Please use AdwStyleManager:color-scheme instead.

(gnome-todo:171718): Gtk-CRITICAL **: 21:59:03.457: gtk_popover_menu_add_child: assertion 'GTK_IS_POPOVER_MENU (popover)' failed

(gnome-todo:171718): Gtk-CRITICAL **: 21:59:03.480: gtk_stack_add_named: assertion 'GTK_IS_STACK (stack)' failed

(gnome-todo:171718): Gtk-CRITICAL **: 21:59:03.507: gtk_stack_add_named: assertion 'GTK_IS_STACK (stack)' failed

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jan 1, 2022
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 1, 2022
@ofborg ofborg bot requested a review from dasj19 January 1, 2022 22:29
@jtojnar
shortwave: mark as broken
d8ce072 
Crashes at runtime:

(de.haeckerfelix.Shortwave:347903): Gtk-ERROR **: 00:33:56.355: failed to add UI from resource /de/haeckerfelix/Shortwave/gtk/featured_carousel.ui: .:12:50 Invalid property: AdwCarousel.animation_duration
@jtojnar jtojnar marked this pull request as ready for review January 1, 2022 23:37
@jtojnar
Copy link
Member Author

jtojnar commented Jan 1, 2022

Checked all libadwaita apps and updated them or marked them as broken when no update (not even in git) is available. notejot is done separately in #153022

@ofborg ofborg bot requested review from austinbutler and lasandell January 2, 2022 00:34
@jtojnar jtojnar merged commit 548dc7c into NixOS:staging Jan 2, 2022
@jtojnar jtojnar deleted the adw1 branch January 2, 2022 09:54
@jtojnar jtojnar mentioned this pull request Jan 2, 2022
Closed
12 tasks
@jtojnar
Copy link
Member Author

jtojnar commented Jan 2, 2022 •
edited
Loading

Oops, I forgot to fix the libportal dependents’ builds: #153225

@jtojnar jtojnar mentioned this pull request Jan 2, 2022
Merged
13 tasks
@mikroskeem
Copy link
Member

mikroskeem commented Jan 3, 2022

Seems like this verison bump broke gtk3 building on aarch64-darwin - https://gist.github.com/mikroskeem/4ea02750a77d30f6ba9b25cb4d803ebf

@mikroskeem mikroskeem mentioned this pull request Jan 3, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@dotlambda dotlambda Awaiting requested review from dotlambda

@hedning hedning Awaiting requested review from hedning

@amaxine amaxine Awaiting requested review from amaxine

@dasj19 dasj19 Awaiting requested review from dasj19

@austinbutler austinbutler Awaiting requested review from austinbutler

@lasandell lasandell Awaiting requested review from lasandell

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) This PR adds a new package 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtojnar @mikroskeem @dasj19