guile: fix non-existing libunistring include path#146871
Merged
r-burns merged 1 commit intoNixOS:stagingfrom Oct 15, 2022
Merged
guile: fix non-existing libunistring include path#146871r-burns merged 1 commit intoNixOS:stagingfrom
r-burns merged 1 commit intoNixOS:stagingfrom
Conversation
Contributor
|
@ofborg eval |
r-burns
reviewed
Nov 21, 2021
Contributor
There was a problem hiding this comment.
Thanks! I think the same needs to be done for Guile 2.0 and 2.2 as well
ofborg
bot
added
10.rebuild-darwin: 1-10
ofborg
bot
added
10.rebuild-darwin: 501+
Contributor
|
Needs to target staging due to the rebuild count, but otherwise LGTM |
The include/ directory for libunistring is inside the libunistring.dev package, not libunistring, thus the .pc file was pointing to a non-existing path.
ofborg
bot
added
10.rebuild-darwin: 101-500
13 tasks
Contributor
|
Sorry for the long wait, let's go ahead and merge this. |
Janik-Haag
added
the
12.first-time contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The include/ directory for libunistring is inside the libunistring.dev
package, not libunistring, thus the .pc file was pointing to a
non-existing path.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes