spoof-mac: add pythonImportsCheck#145665
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Nov 13, 2021
Merged
Conversation
ofborg
bot
added
11.by: package-maintainer
Comment on lines
16
to
17
Contributor
There was a problem hiding this comment.
You can keep this line, it doesn't influence pythonImportsCheck and AFAIK it is faster since it doesn't run a checkPhase: https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#using-pythonimportscheck-using-pythonimportscheck
siraben
force-pushed
the
spoof-mac-pythonImportsCheck
branch
from
bd83bd0 to
0d6fceb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Address @SuperSandro2000's comment in #137071. Thanks!
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)