Skip to content

spoof-mac: init at unstable-2018-01-27#137071

Merged
siraben merged 1 commit intoNixOS:masterfrom
siraben:spoof-mac-init
Sep 8, 2021
Merged

spoof-mac: init at unstable-2018-01-27#137071
siraben merged 1 commit intoNixOS:masterfrom
siraben:spoof-mac-init

Conversation

@siraben
Copy link
Member

@siraben siraben commented Sep 8, 2021

Motivation for this change

Scratching my own itch. I have this package installed via Homebrew but didn't bother to package it up until now. Tested on darwin.

$ sudo ./result/bin/spoof-mac list
Password:
- "Wi-Fi" on device "en0" with MAC address <addr1>
...
$ sudo ./result/bin/spoof-mac randomize en0
$ sudo ./result/bin/spoof-mac list         
- "Wi-Fi" on device "en0" with MAC address <addr1> currently set to 00:50:56:4E:29:FC
...
$ sudo ./result/bin/spoof-mac reset en0    
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@siraben
Copy link
Member Author

siraben commented Sep 8, 2021

Result of nixpkgs-review pr 137071 run on x86_64-darwin 1

1 package built:
  • spoof-mac

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 8, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Sep 8, 2021

Result of nixpkgs-review pr 137071 at 21cb9e8 run on x86_64-linux 1

1 package built successfully:
  • spoof-mac
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/tools/networking/spoof-mac/default.nix:20:0:

       |
    20 |     description = "Change your MAC address for debugging purposes";
       | ^
    

Result of nixpkgs-review pr 137071 at 21cb9e8 run on aarch64-linux 1

1 package built successfully:
  • spoof-mac
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/tools/networking/spoof-mac/default.nix:20:0:

       |
    20 |     description = "Change your MAC address for debugging purposes";
       | ^
    

@fabaff
Copy link
Member

fabaff commented Sep 8, 2021

Related to #81418

@siraben siraben merged commit 09cd65b into NixOS:master Sep 8, 2021
@siraben siraben deleted the spoof-mac-init branch September 8, 2021 16:21
propagatedBuildInputs = [ docopt ];

# No tests
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a pythonImportsCheck.

@siraben siraben mentioned this pull request Nov 12, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants