Skip to content

zfsUnstable: 2.1.1 -> 2021-11-11#145483

Closed
hmenke wants to merge 1 commit intoNixOS:masterfrom
hmenke:zfs
Closed

zfsUnstable: 2.1.1 -> 2021-11-11#145483
hmenke wants to merge 1 commit intoNixOS:masterfrom
hmenke:zfs

Conversation

@hmenke
Copy link
Copy Markdown
Member

@hmenke hmenke commented Nov 11, 2021

Motivation for this change

With this change zfsUnstable will always track the latest master branch and has all kernel compatibility checks disabled. This allows using zfsUnstable with kernels that have not been marked compatible by upstream.

Alternative to #145458

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@hmenke
Copy link
Copy Markdown
Member Author

hmenke commented Nov 11, 2021

@Mic92

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 11, 2021
With this change zfsUnstable will always track the latest master branch
and has all kernel compatibility checks disabled. This allows using
zfsUnstable with kernels that have not been marked compatible by
upstream.
@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Nov 11, 2021

I am just a bit worried that this could make it harder to know when to upgrade.
Following releases or release candidates is a bit easier.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 11, 2021
@hmenke
Copy link
Copy Markdown
Member Author

hmenke commented Nov 11, 2021

Well, it is either one or the other.

Either we follow releases and release candidates but then we also have to adhere to upstream's compatibility checks or we just throw all compatibility out of the window and just follow the master branch.

In my personal opinion, the zfsUnstable package should be removed altogether and people who want to mix and match incompatible kernels and ZFS version should use overlays. That way they at least cannot point the finger at the maintainers if their pool is corrupted.

@hmenke hmenke mentioned this pull request Nov 11, 2021
12 tasks
@hmenke
Copy link
Copy Markdown
Member Author

hmenke commented Nov 11, 2021

Result of nixpkgs-review pr 145483 run on x86_64-linux 1

1 package blacklisted:
  • nixos-install-tools
1 package failed to build:
  • linuxKernel.packages.linux_hardened.zfsUnstable (linuxKernel.packages.linux_5_10_hardened.zfsUnstable)
19 packages built:
  • linuxKernel.packages.linux_4_14.zfsUnstable
  • linuxKernel.packages.linux_4_14_hardened.zfsUnstable
  • linuxKernel.packages.linux_4_19.zfsUnstable
  • linuxKernel.packages.linux_4_19_hardened.zfsUnstable
  • linuxKernel.packages.linux_4_4.zfsUnstable
  • linuxKernel.packages.linux_4_9.zfsUnstable
  • linuxKernel.packages.linux_5_10.zfsUnstable
  • linuxKernel.packages.linux_5_14.zfsUnstable
  • linuxKernel.packages.linux_5_14_hardened.zfsUnstable
  • linuxKernel.packages.linux_5_15.zfsUnstable
  • linuxKernel.packages.linux_5_4.zfsUnstable
  • linuxKernel.packages.linux_5_4_hardened.zfsUnstable
  • linuxKernel.packages.linux_latest_libre.zfsUnstable
  • linuxKernel.packages.linux_libre.zfsUnstable
  • linuxKernel.packages.linux_lqx.zfsUnstable
  • linuxKernel.packages.linux_testing_bcachefs.zfsUnstable
  • linuxKernel.packages.linux_xanmod.zfsUnstable
  • linuxKernel.packages.linux_zen.zfsUnstable
  • zfsUnstable

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Nov 11, 2021

Well, it is either one or the other.

Either we follow releases and release candidates but then we also have to adhere to upstream's compatibility checks or we just throw all compatibility out of the window and just follow the master branch.

In my personal opinion, the zfsUnstable package should be removed altogether and people who want to mix and match incompatible kernels and ZFS version should use overlays. That way they at least cannot point the finger at the maintainers if their pool is corrupted.

If you don't want to maintain zfsUnstable, I am fine with that. I can also take over maintenance for it.

@hmenke
Copy link
Copy Markdown
Member Author

hmenke commented Nov 11, 2021

This PR was a stupid idea, sorry.

@hmenke hmenke closed this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants