Conversation
|
I tested this for a few days on my laptop. |
|
|
@hmenke should I do the same for zfs stable? I will test this version now for linux 5.15. |
|
I think I'll just write an email to the OpenZFS maintainers and ask them to merge and bump kernel compatibility in a more timely manner. |
|
Another option would be to change the documentation for the |
I only remember in the past this used to be not enough because sometimes PRs where needed to fix kernel compatibility. But it could be that things changed. |
|
@Mic92 What do you think of hmenke@2b1e906? That is probably a good middle ground. See also #145485 |
I think I prefer that approach. |
|
It seems like there is still discussion going on in #145485 I would like to go ahead and merge this. As it is working for me. |
|
I don't think, disabling the compatibility check without a message in the release notes is a good idea. |
I don't understand. This pr does not disable any compatibility checks. |
|
Yes, it does. ZFS 2.1.1 is not compatible with Linux 5.15. https://github.com/openzfs/zfs/blob/zfs-2.1.1/META#L9 |
|
Well, linux 5.15 was released two weeks after this zfs release but there were no breaking changes after that - the current version of zfs already had build fixes for 5.15 based on linux master at the time. |
|
Even if you look at the next patch release of zfs there are no changes related to linux 5.15: https://github.com/openzfs/zfs/commits/zfs-2.1.2-staging |
|
I'm extremely unhappy with this “solution” because in a few weeks we will have the exact same problem again and now the upstream compatibility notes do not hold anymore, but the branch-off for 21.11 is imminent, so this should just be merged to at least have something to work with. |
|
We can still backport |
|
This should be reverted. Upstream says that the maximum version for 2.1.1 is 5.14 and this pull request does not build because https://github.com/Mic92/nixpkgs/blob/86e057aa5b6b44aa20b65ed194ec359e897bd89d/pkgs/os-specific/linux/zfs/default.nix#L19 was not updated. Updating zfsStable just because it works in your specific configuration could place others' data at risk. |
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)