Skip to content

nixos/lxc-container: add /etc/NIXOS marker#144571

Closed
mkg20001 wants to merge 1 commit intoNixOS:masterfrom
mkg20001:lxd-marker
Closed

nixos/lxc-container: add /etc/NIXOS marker#144571
mkg20001 wants to merge 1 commit intoNixOS:masterfrom
mkg20001:lxd-marker

Conversation

@mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Nov 4, 2021

Motivation for this change

nixos-install would add this automatically, but this doesn't happen since this is a container

This is needed so LXD can easily detect the distribution
(see https://github.com/lxc/lxd/pull/9471 for more details)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

nixos-install would add this automatically, but this doesn't happen since this is a container

This is needed so LXD can easily detect the distribution
(see https://github.com/lxc/lxd/pull/9471 for more details)
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 4, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 4, 2021
@Artturin
Copy link
Member

Artturin commented Nov 4, 2021

Is the activation script run in a container? #130388

@mkg20001
Copy link
Member Author

mkg20001 commented Nov 4, 2021

Yes, I've merged that PR instead

@mkg20001 mkg20001 closed this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants