Skip to content

Check and create /etc/NIXOS during activation#130388

Merged
mkg20001 merged 1 commit intoNixOS:masterfrom
oxalica:fix/etc-nixos-tag-in-activation
Nov 4, 2021
Merged

Check and create /etc/NIXOS during activation#130388
mkg20001 merged 1 commit intoNixOS:masterfrom
oxalica:fix/etc-nixos-tag-in-activation

Conversation

@oxalica
Copy link
Contributor

@oxalica oxalica commented Jul 16, 2021

Motivation for this change

When using tmpfs root, the tag /etc/NIXOS is wiped on every reboot while some programs and packages depend on it. We should check and make it present in activation script.

Related: rust-lang/rust#87187

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 16, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 16, 2021
@Artturin Artturin requested review from danbst and edolstra September 17, 2021 01:04
@Artturin Artturin mentioned this pull request Nov 4, 2021
Closed
12 tasks
@mkg20001 mkg20001 merged commit f37f1b2 into NixOS:master Nov 4, 2021
@oxalica oxalica deleted the fix/etc-nixos-tag-in-activation branch November 4, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danbst danbst Awaiting requested review from danbst

@edolstra edolstra Awaiting requested review from edolstra

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oxalica @mkg20001