Skip to content

foreman: add more platform support#139456

Merged
domenkozar merged 1 commit intoNixOS:masterfrom
zimbatm:foreman-more-platform
Sep 26, 2021
Merged

foreman: add more platform support#139456
domenkozar merged 1 commit intoNixOS:masterfrom
zimbatm:foreman-more-platform

Conversation

@zimbatm
Copy link
Member

@zimbatm zimbatm commented Sep 25, 2021

Motivation for this change

See
https://www.moncefbelyamani.com/understanding-the-gemfile-lock-file/

Apparently you now have to manually add all the platforms that a gem is
supported on.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

See
https://www.moncefbelyamani.com/understanding-the-gemfile-lock-file/

Apparently you now have to manually add all the platforms that a gem is
supported on.
@zimbatm zimbatm mentioned this pull request Sep 25, 2021
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 25, 2021
@domenkozar domenkozar merged commit ce4cf2b into NixOS:master Sep 26, 2021
@github-actions
Copy link
Contributor

Successfully created backport PR #139527 for release-21.05.

@github-actions
Copy link
Contributor

The process '/usr/bin/git' failed with exit code 1

@zimbatm zimbatm deleted the foreman-more-platform branch September 28, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants